The previous maintainer (Damien Nozay, in Cc) of Promoted Builds plugin granted me the persmissions to merge PRs and relelase . Technically I'm the current plugin's maintainer.
I don't think that Groovy is a showstopper for integrating the functionality into Promoted Builds plugin. Personally I would prefer to have a Java-only code due to the maintenability & static analysis reasons, but I will accept Groovy-based pieces if they are tested enough and do not require a special build flow. Best regards, Oleg пятница, 25 сентября 2015 г., 11:20:46 UTC+3 пользователь Daniel Spilker написал: > > Picking up the discussion from > https://issues.jenkins-ci.org/browse/JENKINS-21750. I want to avoid that > the job-dsl-promotions-plugin gets released outside of the Update Center. > That's only a short-term solution. > > The Promoted Builds Plugin does not seem to have a maintainer, but please > correct me if I'm wrong. So if anyone does not agree to add Groovy code to > the Promoted Builds Plugin, please reply and explain. Otherwise I suggest > that Dennis opens a pull request to add the Job DSL extension to the > Promoted Builds Plugin and gets commit access if necessary. > > @Dennis: The plugin parent POM should contain most things necessary to > compile Groovy code. I wanted to point you to > https://github.com/jenkinsci/hello-world-groovy-plugin, but that seems > outdated. > > Daniel > > On Tue, Aug 4, 2015 at 1:00 PM, Kanstantsin Shautsou <[email protected] > <javascript:>> wrote: > >> cut out your gradle and everything should work out of the box. >> >> On Aug 4, 2015, at 13:57, Dennis Schulte <[email protected] <javascript:>> >> wrote: >> >> Mh, src/main/groovy is not enough. There are a lot of plugins I have to >> configure in the pom.xml/build.gradle and the IDE-support is actually not >> very stable. I guess that my pull request will be rejected by the Promoted >> Build Plugin team, because my code contains Groovy ;-) I will ask them >> before I invest a lot of work in it.... >> >> Am Montag, 3. August 2015 09:01:03 UTC+2 schrieb Dennis Schulte: >>> >>> Hello, >>> >>> >>> I would like to add our plugin to the Jenkins plugin list. >>> >>> >>> >>> - URL: https://github.com/codecentric/job-dsl-promotions-plugin >>> - plugin name: job-dsl-promotions-plugin >>> - github name: denschu >>> - jenkins-ci.org UserName: denschu >>> - description: This plugin is an extension for the existing Job DSL >>> Plugin <https://wiki.jenkins-ci.org/display/JENKINS/Job+DSL+Plugin>. >>> With this extension it is possible to generate promotions with the Job >>> DSL. >>> See the Promoted Builds Plugin >>> <https://wiki.jenkins-ci.org/display/JENKINS/Promoted+Builds+Plugin> >>> for further informations about the meaning of Promotions for a Jenkins >>> Job. >>> >>> >>> Thank you and Best Regards >>> Dennis >>> >>> >> -- >> You received this message because you are subscribed to a topic in the >> Google Groups "Jenkins Developers" group. >> To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/jenkinsci-dev/IZ3kBFhIYYg/unsubscribe. >> To unsubscribe from this group and all its topics, send an email to >> [email protected] <javascript:>. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/e6946a1a-a207-4bc4-8fc2-b42021b996f3%40googlegroups.com >> >> <https://groups.google.com/d/msgid/jenkinsci-dev/e6946a1a-a207-4bc4-8fc2-b42021b996f3%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/672AFF66-3334-44B4-B46D-719905104EEF%40gmail.com >> >> <https://groups.google.com/d/msgid/jenkinsci-dev/672AFF66-3334-44B4-B46D-719905104EEF%40gmail.com?utm_medium=email&utm_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/4ac799ae-9f3b-41a9-a44f-738e1c4561ce%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
