Yes, it ay be the best option, because Job DSL plugin already optionally depends on 4 plugins due to the same reason. Daniel (Spilker), WDYT?
> On 27 Sep 2015, at 10:17, Stephen Connolly <[email protected]> > wrote: > > Why can't he optional dep not be inverted and just have job-dsl optionally > depend on promoted builds. > > Would seem to me that promotion is the more "core" functionality than job-dsl > so the onus should be on job-dsl to add support for promoted builds rather > than the other way. > > In any case I see nothing wrong with having this as a separate plugin either > > On Sunday 27 September 2015, Damien <[email protected] > <mailto:[email protected]>> wrote: > Hi All, > as Oleg mentioned, he is the current maintainer. As my current job > responsibilities does not involve using Jenkins as much, I don't have a > strong opinion what the direction is. Groovy or Java is irrelevant to me as > long as a strong focus on maintainability and testability remains. > > good luck with the merge. > > On Sat, Sep 26, 2015 at 3:16 PM, Oleg Nenashev <[email protected] > <javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote: > The previous maintainer (Damien Nozay, in Cc) of Promoted Builds plugin > granted me the persmissions to merge PRs and relelase . Technically I'm the > current plugin's maintainer. > > I don't think that Groovy is a showstopper for integrating the functionality > into Promoted Builds plugin. Personally I would prefer to have a Java-only > code due to the maintenability & static analysis reasons, but I will accept > Groovy-based pieces if they are tested enough and do not require a special > build flow. > > Best regards, > Oleg > > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <javascript:_e(%7B%7D,'cvml','jenkinsci-dev%[email protected]');>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CAAe5jyNwkCaURREs3WAbpeFk8QHHgct7UvUAnEby-EVBXF7DGA%40mail.gmail.com > > <https://groups.google.com/d/msgid/jenkinsci-dev/CAAe5jyNwkCaURREs3WAbpeFk8QHHgct7UvUAnEby-EVBXF7DGA%40mail.gmail.com?utm_medium=email&utm_source=footer>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. > > > -- > Sent from my phone > > -- > You received this message because you are subscribed to a topic in the Google > Groups "Jenkins Developers" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/jenkinsci-dev/IZ3kBFhIYYg/unsubscribe > <https://groups.google.com/d/topic/jenkinsci-dev/IZ3kBFhIYYg/unsubscribe>. > To unsubscribe from this group and all its topics, send an email to > [email protected] > <mailto:[email protected]>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMwpJ0Rb6bcSeZqb%2B92uXoBQCnuo8dsoKqP%2BtejTCCYYDQ%40mail.gmail.com > > <https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMwpJ0Rb6bcSeZqb%2B92uXoBQCnuo8dsoKqP%2BtejTCCYYDQ%40mail.gmail.com?utm_medium=email&utm_source=footer>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/6AA7F6BE-3E4C-4038-A8BD-A7EFD4F03151%40gmail.com. For more options, visit https://groups.google.com/d/optout.
