You don't need to trial automatic code formatting it to know it's going to
produce a terrible result.
Trivial example 101. Which is the more easily parseable to the human eye?
periodFormatter = new PeriodFormatterBuilder()
.printZeroAlways()
.appendDays().appendSuffix("d ")
.appendHours().appendSuffix("h ")
.appendMinutes().appendSuffix("m")
.toFormatter();
or
periodFormatter = new PeriodFormatterBuilder().printZeroAlways()
.appendDays()
.appendSuffix("d ").appendHours().appendSuffix("h
")
.appendMinutes().appendSuffix("m").toFormatter();
I know which I'd rather be faced with when maintaining code.
On Mon, Oct 26, 2015 at 9:55 PM, Mark Waite <[email protected]>
wrote:
>
>
> On Mon, Oct 26, 2015 at 1:21 PM Stephen Connolly <
> [email protected]> wrote:
>
>> I think that the best way to do this is via an experiment in plugins...
>> If we get a critical mass of plugins adopting a mostly similar set of rules
>> then and only then should we think about applying them to core
>>
>>
> I volunteer to experiment with a branch of the git client plugin as a
> first candidate. I'd limit the formatting to newer files and files that
> I've created myself so that the "diff wall" won't be as difficult. Older
> files with wildly divergent formatting styles will remain that way as part
> of the first phase of the experiment.
>
> That will give a chance to evaluate Nigel's concern for the impact on
> fluent API calls (since there are several fluent interfaces in the git
> client plugin).
>
> Mark Waite
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtHbxMpH1RTwRMiYuDj71pVi1fTSsUFbHTpEh%3DeYGMNezg%40mail.gmail.com
> <https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtHbxMpH1RTwRMiYuDj71pVi1fTSsUFbHTpEh%3DeYGMNezg%40mail.gmail.com?utm_medium=email&utm_source=footer>
> .
>
> For more options, visit https://groups.google.com/d/optout.
>
--
You received this message because you are subscribed to the Google Groups
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-dev/CAPYP83TJO306gyDmEt_fVx88XVZK54gK7O3JhxqSFzDgLrn6Xg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
