Hi Michael, Seems interesting. Just had a look at your plugin, I wonder why you want to call it "logstash-query-plugin", when your code and even your documentation [1] says ES.
Why didn't you call it es or elasticsearch-query-plugin? IMO, even if you query indexes created by logstash, that's still an ES you're querying actually. And I fear that might be misleading for your potential users. (Btw, you may want to use your IDE to try and adjust formating in your main class, makes it a bit harder to eye-parse, my 2 cents). [1] https://github.com/mikee805/logstash-query-plugin/blob/master/src/main/resources/org/jenkinsci/plugins/logstashquery/LogstashQueryBuilder/help-useSSL.html#L2 2015-11-24 6:12 GMT+01:00 Michael Epstein <[email protected]>: > Github.com project: https://github.com/mikee805/logstash-query-plugin > Repo name: logstash-query-plugin > Github.com username: mikee805 > Jenkins-ci.org username: mikee805 > Description: At our company we use logstash to store our logs and Jenkins > to run jobs and do builds. The need for away to alert from logstash as part > of a work flow is evident: > > > https://groups.google.com/forum/m/#!msg/elasticsearch/UcGrodpB3r4/FeqhjMFZ7q0J > > Using Jenkins is a simpl way to hook in. > > Please let me know if you have any questions or concerns. > > Thank you for your time and consideration, > Mike > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/c3627698-727e-4b62-b162-6103e6305f85%40googlegroups.com > . > For more options, visit https://groups.google.com/d/optout. > -- Baptiste <Batmat> MATHUS - http://batmat.net Sauvez un arbre, Mangez un castor ! -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS7Xq39w0SS1f2XexZ4Cb64_svJtdQRzFUrw6YFs5LAjGw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
