I would like to re-submit with the following: https://github.com/mikee805/elasticsearch-query-plugin
Thanks, Mike On Wednesday, December 9, 2015 at 4:02:29 PM UTC-8, Michael Epstein wrote: > > Good points all; I have actually renamed it on my local and started > working on making it more generic so my plugin can search ES in general by > providing indexes or use the ones generated by logstash. > > On Thursday, December 3, 2015 at 12:04:22 PM UTC-8, Michael Neale wrote: >> >> Good point. This plugin is quite different to that one. Yes calling it >> something with "elastic search" in the name probably makes more sense >> On Thu, 3 Dec 2015 at 9:06 PM, Oleg Nenashev <[email protected]> wrote: >> >>> In my mind, if I see a logstash-blah-plugin for Jenkins, I'd think it's >>>> a plugin to somehow *push* logs somewhere (es, graphite, you name it). >>>> Again, I've only read the code very quickly so I may be wrong, but this >>>> plugin seems more like it's designed to *search* an es instance and >>>> alert: >>>> >>> >>> There is such plugin :) >>> https://wiki.jenkins-ci.org/display/JENKINS/Logstash+Plugin >>> >>> So the proposed name for the second plugin was not good >>> >>> 2015-12-03 13:01 GMT+03:00 Baptiste Mathus <[email protected]>: >>> >>>> Well, actually IIUC the code hits an ES instance, on indices named >>>> "logstash-*", so I'd argue it has more to do with ES than with logstash... >>>> (and logstash-* is a default name, so it could btw be totally different). >>>> >>>> In my mind, if I see a logstash-blah-plugin for Jenkins, I'd think it's >>>> a plugin to somehow *push* logs somewhere (es, graphite, you name it). >>>> Again, I've only read the code very quickly so I may be wrong, but this >>>> plugin seems more like it's designed to *search* an es instance and >>>> alert: >>>> >>>> " Simple builder that queries logstash indexes in *elastic search* to >>>> use for downstream notifications" >>>> >>>> https://github.com/mikee805/logstash-query-plugin/blob/master/src/main/java/org/jenkinsci/plugins/logstashquery/LogstashQueryBuilder.java#L76 >>>> >>>> >>>> 2015-12-03 4:28 GMT+01:00 Michael Neale <[email protected]>: >>>> >>>>> Elastic Search (the org/company) recently renamed to just elastic. >>>>> If it is just about logs, logstash makes sense, but if it is for that >>>>> whole stack of things, some folk call it the "ELK" stack for "elastic >>>>> search, logstash and kibana". Not sure if elk-jenkins makes sense (too >>>>> obscure?) >>>>> >>>>> This plugin is very logstash specific so I think it is right to use >>>>> that in the name (and many people use logstash without thinking "elastic >>>>> search"). >>>>> >>>>> >>>>> On Thursday, December 3, 2015 at 8:27:28 AM UTC+11, Oleg Nenashev >>>>> wrote: >>>>>> >>>>>> Elasticsearch and Logstash are heavily integrated with each other. >>>>>> Maybe it makes sense to have a generic Elasticsearch plugin. E.g. >>>>>> there is such plugin there: >>>>>> https://github.com/speedledger/elasticsearch-jenkins >>>>>> It could be integrated into the community. >>>>>> >>>>>> After that it would be possible to build a specialized logstash >>>>>> plugin on the >>>>>> >>>>>> среда, 2 декабря 2015 г., 1:34:54 UTC+3 пользователь Baptiste Mathus >>>>>> написал: >>>>>>> >>>>>>> Hi Michael, >>>>>>> >>>>>>> Seems interesting. Just had a look at your plugin, I wonder why you >>>>>>> want to call it "logstash-query-plugin", when your code and even your >>>>>>> documentation [1] says ES. >>>>>>> >>>>>>> Why didn't you call it es or elasticsearch-query-plugin? IMO, even >>>>>>> if you query indexes created by logstash, that's still an ES you're >>>>>>> querying actually. >>>>>>> And I fear that might be misleading for your potential users. >>>>>>> >>>>>>> (Btw, you may want to use your IDE to try and adjust formating in >>>>>>> your main class, makes it a bit harder to eye-parse, my 2 cents). >>>>>>> >>>>>>> [1] >>>>>>> https://github.com/mikee805/logstash-query-plugin/blob/master/src/main/resources/org/jenkinsci/plugins/logstashquery/LogstashQueryBuilder/help-useSSL.html#L2 >>>>>>> >>>>>>> 2015-11-24 6:12 GMT+01:00 Michael Epstein <[email protected]>: >>>>>>> >>>>>>>> Github.com project: >>>>>>>> https://github.com/mikee805/logstash-query-plugin >>>>>>>> Repo name: logstash-query-plugin >>>>>>>> Github.com username: mikee805 >>>>>>>> Jenkins-ci.org username: mikee805 >>>>>>>> Description: At our company we use logstash to store our logs and >>>>>>>> Jenkins to run jobs and do builds. The need for away to alert from >>>>>>>> logstash >>>>>>>> as part of a work flow is evident: >>>>>>>> >>>>>>>> >>>>>>>> https://groups.google.com/forum/m/#!msg/elasticsearch/UcGrodpB3r4/FeqhjMFZ7q0J >>>>>>>> >>>>>>>> Using Jenkins is a simpl way to hook in. >>>>>>>> >>>>>>>> Please let me know if you have any questions or concerns. >>>>>>>> >>>>>>>> Thank you for your time and consideration, >>>>>>>> Mike >>>>>>>> >>>>>>>> -- >>>>>>>> You received this message because you are subscribed to the Google >>>>>>>> Groups "Jenkins Developers" group. >>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>> send an email to [email protected]. >>>>>>>> To view this discussion on the web visit >>>>>>>> https://groups.google.com/d/msgid/jenkinsci-dev/c3627698-727e-4b62-b162-6103e6305f85%40googlegroups.com >>>>>>>> . >>>>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Baptiste <Batmat> MATHUS - http://batmat.net >>>>>>> Sauvez un arbre, >>>>>>> Mangez un castor ! >>>>>>> >>>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Jenkins Developers" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/jenkinsci-dev/75e99166-ae1a-4d61-a2ae-4e7ca1151ab5%40googlegroups.com >>>>> >>>>> <https://groups.google.com/d/msgid/jenkinsci-dev/75e99166-ae1a-4d61-a2ae-4e7ca1151ab5%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> >>>> >>>> -- >>>> Baptiste <Batmat> MATHUS - http://batmat.net >>>> Sauvez un arbre, >>>> Mangez un castor ! >>>> >>>> -- >>>> You received this message because you are subscribed to a topic in the >>>> Google Groups "Jenkins Developers" group. >>>> To unsubscribe from this topic, visit >>>> https://groups.google.com/d/topic/jenkinsci-dev/R8RFtHTFCxo/unsubscribe >>>> . >>>> To unsubscribe from this group and all its topics, send an email to >>>> [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS7TB5kkKNV69Oa6nuRoKb7cMeVRED%3DtwiBgc3EFdGSpGw%40mail.gmail.com >>>> >>>> <https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS7TB5kkKNV69Oa6nuRoKb7cMeVRED%3DtwiBgc3EFdGSpGw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> -- >>> You received this message because you are subscribed to a topic in the >>> Google Groups "Jenkins Developers" group. >>> To unsubscribe from this topic, visit >>> https://groups.google.com/d/topic/jenkinsci-dev/R8RFtHTFCxo/unsubscribe. >>> To unsubscribe from this group and all its topics, send an email to >>> [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDuGH_bJ%2B8HxoLU%2BWptJkCbk2hm_Fajw7-3CZqcgV%2BEgA%40mail.gmail.com >>> >>> <https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDuGH_bJ%2B8HxoLU%2BWptJkCbk2hm_Fajw7-3CZqcgV%2BEgA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/e806ca37-34cc-4f8f-a686-9f63262bb711%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
