> On Dec 15, 2015, at 18:43, Surya Gaddipati <[email protected]> wrote: > > Hi Yoann, > Thank you for your response. > > > I was wondering what was missing to rewrite a simplified version of it. > > So here are couple of things that I found needed to be changed > > 1. changed to use spotify-docker api client instead of command line, I needed > it to talk to docker-swarm to allocated nodes Binary wrapping is solution that CloudBees choose for their plugins and seems this plugin follow it to have compatibility. Before they released first *docker* plugins i proposed to cooperate work on some library but they rejected it. > 2. Slaves are allocated based on job label not job property, much like cloud > plugins Thats feature and required to have ability to specify container from job (imagine that you can’t request admin to change images). > 3. We didn't need to run builds in another image/side image ect, we use > docker-compose to run builds. Ok, it just one of features. > 4. Had to remove couple of hacks like this > <https://github.com/ndeloof/docker-slaves-plugin/blob/master/src/main/java/com/cloudbees/jenkins/plugins/dockerslaves/DockerComputerLauncher.java#L84>, > since we don't store builds on disk. > 5. We didn't need jenkins user mounting . > > This plugin simply allocates a new slave via jnlp/docker api calls. There is > no extra magic. > > Surya P.S. i’m working on having ability to share slave configuration between Cloud configuration and Job Properties. Also with future docker-java release it will be possible to run remoting with pipes (spotify doesn’t support it afaik, dunno why you so want enforce plugins to use it). But that will be in yet-another-docker-plugin. > > > > > On Sunday, December 13, 2015 at 12:53:44 PM UTC-6, Surya Gaddipati wrote: > This is not a hosting request. I am hoping to get some feedback on the plugin > and see if its worth hosting/merging into other plugins. > > Details are in the readme of the project > https://github.com/suryagaddipati/jenkins-docker-slaves > <https://github.com/suryagaddipati/jenkins-docker-slaves> > > > Pls, let me know if you have any questions. > > Surya > > > -- > You received this message because you are subscribed to a topic in the Google > Groups "Jenkins Developers" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/jenkinsci-dev/ruikEEsF_bc/unsubscribe > <https://groups.google.com/d/topic/jenkinsci-dev/ruikEEsF_bc/unsubscribe>. > To unsubscribe from this group and all its topics, send an email to > [email protected] > <mailto:[email protected]>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/57db95e2-f8df-4015-9d91-3705a852aa3d%40googlegroups.com > > <https://groups.google.com/d/msgid/jenkinsci-dev/57db95e2-f8df-4015-9d91-3705a852aa3d%40googlegroups.com?utm_medium=email&utm_source=footer>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>.
-- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/34912DB1-1FD6-411B-94E9-630315893DB2%40gmail.com. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: Message signed with OpenPGP using GPGMail
