Hi Kostya, I understand your concern, but messages of such kind can be considered as a personal offense. Kohsuke is not the only person committing in such way, so it's definitely a wider problem, which requires a discussion. BTW currently there is no policy prohibiting such approach, so the direct commits are generally valid even if they smell bad.
I'm +1 on prohibiting direct pushes to the master branches for everybody and in all repos. And Jenkins core core is not an exception. It makes the current release and changelogging approach a bit problematic, but it's another story. if you signed ICLA and do some questionable changes into master (here i see > 2 violations) person should get core access removal, right? Nope. There is no such policy in Jenkins project. If you have any concerns about particular contributors, raise the topic to the governance meeting. It's the *ONLY* way for discussing such topics. воскресенье, 20 декабря 2015 г., 17:03:40 UTC+3 пользователь Kanstantsin Shautsou написал: > > Situation: people doing reviews, blocking PRs for weeks,months,years while > some people do direct commits to core master without any reviews. > This ends to situations when master gets broken state that reflects on PR > builds verification, i.e. > https://github.com/jenkinsci/jenkins/commit/d86a88ab042cc55530d91e745af9e0886e8eeb79 > Unreviewed changes adds chaos. While people reviewing and close to get rid > of unconfigurable settings in > https://github.com/jenkinsci/jenkins/pull/1914 one person is doing direct > master changes > https://github.com/jenkinsci/jenkins/commit/653fbdb65024b1b528e21f682172885f7111bba9 > > <https://www.google.com/url?q=https%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins%2Fcommit%2F653fbdb65024b1b528e21f682172885f7111bba9&sa=D&sntz=1&usg=AFQjCNGfejtJii5ClN4CxzyDP_BzWpWFag> > > Proposal: stop doing such unreviewed changes and forbid direct master > commits (either at all, either only for mentioned person). > > PS. AFAIR/AFAIK if you signed ICLA and do some questionable changes into > master (here i see 2 violations) person should get core access removal, > right? > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/630f6633-d494-4726-8c21-d63890ce040a%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
