Hi,

I have sent a PR that removes dead code 
(https://github.com/jenkinsci/jenkins/pull/1957). Some of the suggested 
changes are to remove readResolve methods because the classes that contain 
those methods do not implement java.io.Serializable. XStream, as far as I 
know, uses the readResolve when it is dealing with the ObjectOutputStream 
and according the official Java documentation, just Serialiable and 
Externalizable elements can use readResolve. 

Then, my question is if these classes:


   - hudson.model.ListView
   - hudson.model.PaneStatusProperties
   - hudson.model.ParametersAction
   - hudson.model.Queue
   - hudson.security.csrf.DefaultCrumbIssuer
   - hudson.tasks.BatchFile
   - hudson.tasks.BuildTrigger
   - hudson.tasks.Shell
   - hudson.tools.BatchCommandInstaller
   - hudson.tools.CommandInstaller
   - hudson.util.RobustReflectionConverter
   - jenkins.model.ArtifactManagerConfiguration
   - jenkins.security.QueueItemAuthenticatorConfiguration
   
should be java.io.Serializable or the methods need to be removed?

Thank you in advance

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/d670360c-93f8-4382-84f4-694039a02f8f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to