I disagree, it would be a pain to have to mark everything that could be serializable with the interface. It works quite well right now as is.
On Tue, Dec 22, 2015, 12:39 Raquel Pau Fernández <[email protected]> wrote: > Thanks Jesse for your feedback :-) > > I really appreciate your explanation. I will remove from my walkmod > configuration the "removal option" of the serialization methods. Tomorrow, > I will try to send again another PR to discuss for the rest of the changes. > > Can you give me some clues about what packages and classes I would need to > take a look? (or just do I need to find dependencies for XStream and JBoss > Marshalling? ) Is there any documentation in somewhere? I would like to > understand the code and "try" to create a test for it. > > However, what I mean is that even the java.io.Serialiable is not necessary > for these libraries, if you are serializing objects, these should belong to > this interface. Indeed, this is the purpose of these methods. So, what I > would like to do is thinking about I can create a test to validate if > making them Serializable provokes an error. Would it be helpful as well to > you? > > Thanks again for your support > > > El martes, 22 de diciembre de 2015, 16:16:16 (UTC+1), Jesse Glick escribió: >> >> It is a feature of XStream that it does not require any marker interface. >> Its semantics are intentionally aligned with, but not identical to, Java >> serialization (which Jenkins also uses, for different purposes). Workflow >> code also uses JBoss Marshalling, again similar but not identical to Java >> serialization. There is no mechanical way to determine which, if any, of >> these systems is/are used on a given class in Jenkins; you just have to >> understand the code. >> > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/fb2bdd92-a86f-44b9-951f-f99a19ae6194%40googlegroups.com > <https://groups.google.com/d/msgid/jenkinsci-dev/fb2bdd92-a86f-44b9-951f-f99a19ae6194%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVdQ-LS%3DhShBcYE5cts2Bg84CZ7FXtAR%3Dkn-TQTFKayRLQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
