On Mon, Jan 18, 2016 at 4:35 AM,  <[email protected]> wrote:
> The current proposal is being pushed to
> https://github.com/andresrc/plugin-pom.

Since there is no PR for the POM itself, I am putting comments here.

`<issueManagement>` does not seem like it belongs. The POM need not be
used by plugins hosted under the Jenkins organization.

AFAIK the test dependency on `jenkins-war` should be on
`<classifier>war-for-test</classifier>`, not `<type>war</type>`.

I would suggest `<preparationGoals>javadoc:javadoc clean
install</preparationGoals>` rather than `<preparationGoals>clean
install javadoc:javadoc</preparationGoals>` since Javadoc generation
is likely a lot faster than running tests, and more likely to be
failing without anyone knowing about it before.

Consider 
https://github.com/jenkinsci/workflow-plugin/blob/master/pom.xml#L201-L211
which I have found invaluable. Could be added later of course.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0ZHQrbgT1QP5G3DxgifLTO4M1g3ZkMv-H7aVK3_1g_XQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to