On Tuesday 19 January 2016, Jesse Glick <[email protected]> wrote:
> On Mon, Jan 18, 2016 at 4:35 AM, <[email protected] <javascript:;>> > wrote: > > The current proposal is being pushed to > > https://github.com/andresrc/plugin-pom. > > Since there is no PR for the POM itself, I am putting comments here. > > `<issueManagement>` does not seem like it belongs. The POM need not be > used by plugins hosted under the Jenkins organization. > > AFAIK the test dependency on `jenkins-war` should be on > `<classifier>war-for-test</classifier>`, not `<type>war</type>`. > > I would suggest `<preparationGoals>javadoc:javadoc clean > install</preparationGoals>` rather than `<preparationGoals>clean > install javadoc:javadoc</preparationGoals>` since Javadoc generation > is likely a lot faster than running tests, and more likely to be > failing without anyone knowing about it before. -1 as that may give a false fail on a clean checkout where the javadoc plugin references generated classes etc and Java 8 is being strict. > > Consider > https://github.com/jenkinsci/workflow-plugin/blob/master/pom.xml#L201-L211 > which I have found invaluable. Could be added later of course. > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] <javascript:;>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0ZHQrbgT1QP5G3DxgifLTO4M1g3ZkMv-H7aVK3_1g_XQ%40mail.gmail.com > . > For more options, visit https://groups.google.com/d/optout. > -- Sent from my phone -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMxQ5fxVpQdeKVyUc2ocJi0vBo1JoFkCfGYDiHxN0Zg_1Q%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
