Hmm, there must be some disconnect here. The whole "GitHub Organization Folder" functionality is currently divided into 3 pieces in 3 different plugins that do not depend on each other very much, which takes some time to wrap one's head around.
There's OrganizationFolder in branch-api that defines a collection of "something" as a folder (that maps to the org level folder), then there's GitHubSCMNavigator that brings in GitHub specific binding, t hen there's pipeline-multibranch that defines a collection of branches as a folder (that maps to the rep level folder.) This split makes it unintuitive as to where the glue polish needs to go; the kind of glue that I wrote down in this <https://docs.google.com/document/d/1YqB-UcI5Po4LiXCqWcHB-psoEXR9TSCiqlRRGQLzqus/edit#>, such as initial ListView set up, additional FolderProperties, etc. I was under the assumption that you want to maintain the current trinity, in which case the only place it can go would be another plugin. But you seem to be saying that they should all go to github-branch-source. That is, that plugin will get such dependencies like pipeline-mutlibranch and branch-api. I have no problem with it, but I just want to make sure I understand you correctly. Also, thanks for pointing out MultiBranchProjectFactory.createProject, but WorkflowMultiBranchProjectFactory.doCreateProject doesn't use it at all today, and even if that code is made to understand some attributes, one can only do what this plugin anticipates. And I still need to use something else for customizing OrganizationFolder and WorkflowJob. I think ItemListener gets the job done, but what else do you suggest? 2016-03-01 8:02 GMT-08:00 Jesse Glick <[email protected]>: > On Mon, Feb 29, 2016 at 8:02 PM, Kohsuke Kawaguchi <[email protected]> wrote: > > Many of those UI improvements can be done as one time configuration of > > OragnizationFolder, MultiBranchProject, etc after they are created. This > > include icons, initial view and their columns, additional FolderProperty > > etc. > > > > Therefore we need to implement ItemListener > > No. See `MultiBranchProjectFactory.createProject` (`attributes`). > > > We should create a "GitHub Organization Folder" plugin > > How is this not `github-branch-source`? > > > a convenient aggregator > > -1 on new aggregators. A properly written setup wizard should > supersede the concept. > -- Kohsuke Kawaguchi -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAN4CQ4xZmykC49BVSS-1vBk%3D7icD6mNAriTmnLQMkAoNWy4DmQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
