Hi Jesse,

Sorry for the late follow up, I missed your reply.

Le lundi 19 septembre 2016 19:53:49 UTC+2, Jesse Glick a écrit :
>
> `SonarRunnerBuilder` as a `SimpleBuildStep` looks suspicious. Might 
> `executeSonarQubeScanner` take more than a few seconds to run?


Definitely.
 

> If so, 
> `SimpleBuildStep` is inappropriate; you need to use durable steps, 
> like `sh`.


What is "durable step"? Our primary source of information 
was https://github.com/jenkinsci/pipeline-plugin/blob/master/DEVGUIDE.md 
and it is not mentioned. With Freestyle jobs we were previously using 
the Builder extension point, and according to the DEVGUIDE:

To add support for use of a Builder or Publisher from a pipeline, depend on 
> Jenkins 1.577+, typically 1.580.1 (tips). Then implement SimpleBuildStep.


Do you have some pointers on this concept of durable step? Is it possible 
to migrate a Builder to a durable step?
 

> The same would apply to `AbstractMsBuildSQRunner`s. Unclear 
> to me why you are not using a build wrapper for the msbuild cases, 
>

This is something we were discussing internally but again we are migrating 
from a Builder. There is indeed a strong coupling between these 2 steps, 
but on the other side, all our documentation refers to these two distinct 
steps (begin / end). We think it would be easier for people to understand 
how to write a MSBuild pipeline if we keep the same naming.

Thanks,

Julien
 

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/3e27d367-a158-43b2-8a7a-4d7217c248b5%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to