On Mon, May 8, 2017 at 7:05 PM, Fabien Crespel <[email protected]> wrote: > I believe I have fixed the two issues mentioned there, but since I'm > completely new to the Script Security plugin could someone with experience > (from the security team?) please take a look at these commits: > https://github.com/jenkinsci/cas-plugin/commit/79a9bd1d1d5014bfb2014c5f1244b79e7ade4e93 > https://github.com/jenkinsci/cas-plugin/commit/d8aba2a5507d95ac9c89d222626fdd951e094d09
I did not notice any security flaws from a quick inspection. For the future, if you are requesting review on proposed code changes, I would recommend creating a pull request as this is a more structured way of soliciting line-by-line feedback. You can even request particular reviewers. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3D_eOoLfwYRWQrYVZhdqwH8ExWzbnUymD-e7Wdn5e0Fg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
