Thanks for the review and information :-) I just released version 1.4.0 and made a PR for the Update Center: https://github.com/jenkins-infra/backend-update-center2/pull/139
Le mardi 9 mai 2017 15:29:24 UTC+2, Jesse Glick a écrit : > > On Mon, May 8, 2017 at 7:05 PM, Fabien Crespel <[email protected] > <javascript:>> wrote: > > I believe I have fixed the two issues mentioned there, but since I'm > > completely new to the Script Security plugin could someone with > experience > > (from the security team?) please take a look at these commits: > > > https://github.com/jenkinsci/cas-plugin/commit/79a9bd1d1d5014bfb2014c5f1244b79e7ade4e93 > > > > https://github.com/jenkinsci/cas-plugin/commit/d8aba2a5507d95ac9c89d222626fdd951e094d09 > > > I did not notice any security flaws from a quick inspection. > > For the future, if you are requesting review on proposed code changes, > I would recommend creating a pull request as this is a more structured > way of soliciting line-by-line feedback. You can even request > particular reviewers. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/5c1e2077-6356-4d8b-a308-403aed9b34d1%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
