On 12 June 2017 at 13:11, Stephen Connolly <[email protected]> wrote:
> > > On 12 June 2017 at 12:22, pallen <[email protected]> wrote: > >> Hi Guys, >> >> I'm looking to update the merge/review functionality of the P4 plugin and >> had a few questions: >> > > this week I am pushing the traits changes... you may want to adopt those, > plan accordingly. > > >> >> (1) How does Multibranch determine a PR or Branch is closed, so that it >> is displayed with strikethrough the text? Is this part of the >> retrieve/observe mechanism in the scm-api plugin? >> > > when the scm-api no longer returns the branch or pull request, then it is > considered an orphaned branch. > > orphaned branch jobs cannot be deleted immediately because the orphaned > branch strategy that the user configures may not be able to determine which > branches are eligible for deletion until it has a complete list of orphaned > branches (which means we need to wait for a full scan) > > >> >> For example, PR-46 in the image below: >> >> >> <https://lh3.googleusercontent.com/-Sa4Tgq11dNU/WT536HzlhTI/AAAAAAAAADQ/KNbSX4OgH6UwIsxfUOcyXdhFnvlqprXGQCLcB/s1600/Screen%2BShot%2B2017-06-12%2Bat%2B12.15.28.png> >> >> >> (2) The two tabs, shown above 'Branches' and 'Pull Requests' are these >> just filters set in Multibranch or defined programmatically as part of the >> github plugin? >> > Each SCMHeadCategory that your plugin enumerates will be given its own > tab. You can control the names of these. > > Please read: > > https://github.com/jenkinsci/scm-api-plugin/blob/master/ > docs/implementation.adoc > > It is the documentation for anyone wanting to implement SCM API support in > an SCM plugin > Yes I have to update these docs for traits, but the delta should not be too bad > > >> >> >> Kind regards, >> Paul >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit https://groups.google.com/d/ms >> gid/jenkinsci-dev/f0ef7486-446f-4051-8a9f-d5423a739571%40googlegroups.com >> <https://groups.google.com/d/msgid/jenkinsci-dev/f0ef7486-446f-4051-8a9f-d5423a739571%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMxSbG5US4%3DaiHcVdS5yTz5bvuVNrdWUQ9UQEy178E%3D4cg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
