On 12 June 2017 at 14:45, Paul Allen <[email protected]> wrote: > Hi Stephen, > > (1) Thank you - so if I understand correctly, if retrieve no longer finds > it observer is not called and it appears crossed out. >
Correct > > (2) Should I implement my own SCMHeadCategory to for my P4Head (extends > SCMHead)? If I need different types (e.g. 'Branches', 'Pull Requests') I > need new implementations of SCMHead and a corresponding SCMHeadCategory? > What do the docs say: https://github.com/jenkinsci/scm-api-plugin/blob/master/docs/implementation.adoc Hint: I believe the docs are very explicit on that subject. There is, to my mind, an unambiguous answer directly to your question (somewhere in the middle third of the docs) I really am looking for people to find faults in the docs. If I keep giving people answers then I become the scalability issue. I would much rather that people can solve the problems by reading documentation. That means that my efforts deliver a multiple rather than everything being rate limited by my time and availability. By using the docs and suggesting improvements we make the whole community better. ;-) > I'm using scm-api 2.0.2 and a Jenkins version of 1.642.3 > > Kind regards, > Paul > > > On 12 Jun 2017, at 13:18, Stephen Connolly <stephen.alan.connolly@gmail. > com> wrote: > > > > On 12 June 2017 at 13:11, Stephen Connolly <stephen.alan. > [email protected]> wrote: > >> >> >> On 12 June 2017 at 12:22, pallen <[email protected]> wrote: >> >>> Hi Guys, >>> >>> I'm looking to update the merge/review functionality of the P4 plugin >>> and had a few questions: >>> >> >> this week I am pushing the traits changes... you may want to adopt those, >> plan accordingly. >> >> >>> >>> (1) How does Multibranch determine a PR or Branch is closed, so that it >>> is displayed with strikethrough the text? Is this part of the >>> retrieve/observe mechanism in the scm-api plugin? >>> >> >> when the scm-api no longer returns the branch or pull request, then it is >> considered an orphaned branch. >> >> orphaned branch jobs cannot be deleted immediately because the orphaned >> branch strategy that the user configures may not be able to determine which >> branches are eligible for deletion until it has a complete list of orphaned >> branches (which means we need to wait for a full scan) >> >> >>> >>> For example, PR-46 in the image below: >>> >>> >>> <https://lh3.googleusercontent.com/-Sa4Tgq11dNU/WT536HzlhTI/AAAAAAAAADQ/KNbSX4OgH6UwIsxfUOcyXdhFnvlqprXGQCLcB/s1600/Screen%2BShot%2B2017-06-12%2Bat%2B12.15.28.png> >>> >>> >>> (2) The two tabs, shown above 'Branches' and 'Pull Requests' are these >>> just filters set in Multibranch or defined programmatically as part of the >>> github plugin? >>> >> Each SCMHeadCategory that your plugin enumerates will be given its own >> tab. You can control the names of these. >> >> Please read: >> >> https://github.com/jenkinsci/scm-api-plugin/blob/master/docs >> /implementation.adoc >> >> It is the documentation for anyone wanting to implement SCM API support >> in an SCM plugin >> > > See if you can spot the place where I designed the API so that perforce > can have it's tab called "Change Reviews" instead of "Pull Requests" ;-) > >> >> >>> >>> >>> Kind regards, >>> Paul >>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Jenkins Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit https://groups.google. >>> com/d/msgid/jenkinsci-dev/f0ef7486-446f-4051-8a9f- >>> d5423a739571%40googlegroups.com >>> <https://groups.google.com/d/msgid/jenkinsci-dev/f0ef7486-446f-4051-8a9f-d5423a739571%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit https://groups.google. > com/d/msgid/jenkinsci-dev/CA%2BnPnMxrJEF64Xt5%3DFReOGybeyb0OzFW- > GG5ZSQGXB9qimpz5A%40mail.gmail.com > <https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMxrJEF64Xt5%3DFReOGybeyb0OzFW-GG5ZSQGXB9qimpz5A%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > > > ------------------------------------------------------------ > -------------------- > Perforce Software UK Ltd is registered in England and Wales as company no. > 3816019 at the following address: West Forest Gate, > Wellington Road, Wokingham, > RG40 2AT, UK > -------------------------------------------------------------------------------- > > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit https://groups.google.com/d/ > msgid/jenkinsci-dev/2F8521F2-05D9-4A8C-BBC9-4C27675EC8CB%40perforce.com > <https://groups.google.com/d/msgid/jenkinsci-dev/2F8521F2-05D9-4A8C-BBC9-4C27675EC8CB%40perforce.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMyCD7%2BNfGo6qii6pQXvJ0m1ircodBq8v1WKK%3Dz%3DaNXHOw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
