right - but how is the context that is required indicating the build was successful set?
oh wait...is that handled by some special internal magic by whatever plugin is being used to do the builds vs having to call some step/publisher in the Jenkinsfile itself to set the context? On Mon, Jan 22, 2018 at 4:08 PM, Daniel Beck <[email protected]> wrote: > > > On 22. Jan 2018, at 23:41, Jae Gangemi <[email protected]> wrote: > > > > unfortunately it doesn't look like it will block merging if the build > fails or post back status updates to the PR which would be useful in > preventing some mistakes (i opened a PR the other day and missed a > commit/push that i only found out about after someone tried to pull the PR > and build it locally). > > It's unclear what you mean. > > https://github.com/jenkinsci/repository-connector-plugin/settings/branches > allows you to protect branches to prevent merges while PR checks are > failing. It has nothing to do with the tool that posts commit statuses. > > -- > You received this message because you are subscribed to a topic in the > Google Groups "Jenkins Developers" group. > To unsubscribe from this topic, visit https://groups.google.com/d/ > topic/jenkinsci-dev/X3nHpfaeD9M/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To view this discussion on the web visit https://groups.google.com/d/ > msgid/jenkinsci-dev/48EAB1D9-875B-47D7-A150-27AB283A3FBD%40beckweb.net. > For more options, visit https://groups.google.com/d/optout. > -- -jae -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMshyrtMOZ9Gq9oGUMVN5fy7JLSdvCyhSbR-XFmCeWwwKyzNzA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
