On Friday, March 16, 2018 at 3:05:30 PM UTC, Jesse Glick wrote:
>
> It is important. When a PR branch project is built, `checkout scm` and 
> related features will select a particular commit from the PR (not 
> always the most recent), and may additionally merge it against a 
> particular commit in the base branch. 
>

Ok, the reason I thought it might not be important is that GHBS's 
PullRequest event returns a null revision in case of a PR merge, so I was 
testing that as a first step. I just noticed that the PullRequestSCMHead is 
used by the GHBS events, but its class constructor is also package private 
while I've been using regular SCMHead. I still haven't found where these 
returned heads are later referenced, but I'm worried that GHBS will reject 
any non-PullRequestSCMHeads or revisions in which case there's nothing I 
can do here.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/c615e9ca-3fcc-4c7b-b510-5622660e78c5%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to