On Monday, March 19, 2018 at 8:13:59 AM UTC, Stephen Connolly wrote: > > > What did I do in Gitea plugin? > > If I made the constructor public there, then that’s what we should > probably be doing in GitHub/ Bitbucket >
In Gitea, it seems the SCMHead has a public constructor but the SCMRevision has a protected constructor. My tests have all been with the PR Merge strategy so far, so the SCMRevision hasn't come into play yet (taking the lead from the GH pull request events, it's returned as null from the SCMEvent for merges). On Mon 19 Mar 2018 at 08:13, Stephen Connolly <[email protected]> wrote: > And a final question, would a BranchBuildStrategy work better (ie discover > all PRs but only build one with the matching label criteria) - more asking > to see what your use case is The build solution I have is a bit wacky, involving a multibranch project per build platform (10+). This is because each platform requires a level of paralellization for things like compiler versions and build configurations. It's also very useful to have platforms as a manually buildable unit. I also have a parent/root multibranch project which kicks off a branch/pr in each platform build and collects the results. This acts as *the* build result for inspection by other tools. All of the platform builds use the "Suppress automatic SCM triggering" property (which I thought WAS a branch build strategy until I looked it up just now, so maybe that's irrelevant). With so many multibranch projects, keeping indexing to a minimum is a great bonus which is what I am hoping to achieve with the filter + event system. (https://issues.jenkins-ci.org/browse/JENKINS-43749?focusedCommentId=319032&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-319032 would tame this setup somewhat but that's a problem for the future) -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/400ba937-b98c-4076-9ca0-ba115e8bbbd1%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
