Hi, I am not against removing CLI over Remoting. Or maybe it makes sense to move it to a plugin (without adding it as a detached plugin). But I do not quite get the need to simplify the component structure. It is just a matter of time till we hit another Java-specific test classes & Co. E.g. we may need to create Java11-only tests, or to add tests relying on modules detached from Java 11. I prefer to keep the code ready to such requirements, so revering test-parent would be a step backward IMO
BR, Oleg On Sunday, January 6, 2019 at 4:58:09 PM UTC+1, Mark Waite wrote: > > +1 from me as well. > > On Fri, Jan 4, 2019 at 3:21 PM Jeff Thompson <[email protected] > <javascript:>> wrote: > >> +1 >> >> I support this proposal. We’ve seen another case recently of a problem >> with this antiquated mode. We have had to adjust tests to continue >> supporting it. >> >> I don’t think there is enough value in continuing to support it, >> particularly with the costs to keep coaxing it along. >> >> Jeff Thompson >> >> On Jan 4, 2019, at 2:42 PM, Jesse Glick <[email protected] >> <javascript:>> wrote: >> >> As of JENKINS-41745, merged in Jenkins 2.54 more than a year and a >> half ago, the Remoting transport for the Jenkins CLI has been >> deprecated as inherently hard to secure and just plain unwise. As far >> as I know, all important CLI commands have long since removed any >> dependency on this mode, or offered an alternative mode. The UI warns >> you if you enable it. Is it time to finally remove this code? >> >> I bring this up now because of Java 11 work: >> >> https://github.com/jenkinsci/jenkins/pull/3759 >> >> made the physical layout of Jenkins core more complex, just in order >> to maintain some exploit tests which were really only interesting in >> CLI over Remoting, and not even that interesting anyway after JEP-200. >> (Deserialization attacks via agents could still be launched, but >> again, that would be much harder after JEP-200.) >> >> I propose this `jenkins-test-jdk8` module and its three test suites >> and ysoserial library be deleted, whether or not CLI over Remoting is >> also removed, so that we can remove `jenkins-test-parent` and go back >> to having only `jenkins-test`. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3RN-dRrPFXW%2Bn1S9V8VXDPRqxQL02t0NHcVyqwEq1n3g%40mail.gmail.com >> . >> For more options, visit https://groups.google.com/d/optout. >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/78DB206D-FBA7-4F95-8AE8-AFC5280800CF%40cloudbees.com >> >> <https://groups.google.com/d/msgid/jenkinsci-dev/78DB206D-FBA7-4F95-8AE8-AFC5280800CF%40cloudbees.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > > > -- > Thanks! > Mark Waite > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/28e65655-9fa5-4e51-894a-a45bce6f5a71%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
