It’s not exactly a third opinion because I agree with Jesse. Jenkins build and test structures are already complicated enough. I would hope to not increase that complexity with a clear, demonstrated need.
Jeff Thompson > On Jan 7, 2019, at 7:20 AM, Jesse Glick <[email protected]> wrote: > > On Sun, Jan 6, 2019 at 12:32 PM Oleg Nenashev <[email protected]> wrote: >> maybe it makes sense to move [Remoting-based CLI] to a plugin > > Not possible I am afraid. It either needs to be baked into core and > supported, or deleted. > >> It is just a matter of time till we hit another Java-specific test class > > There is no indication that we will. The only Java 8-specific tests > are those which use ysoserial, which deliberately compiles against > internal JRE classes to simulate deserialization exploits. > >> we may need to create Java11-only tests > > I would hope that if we start having lots of Java 11-specific code, we > should simply decide to drop support for 8 already. In the past when > we needed on occasion to (for example) test some 7+ API when the repo > as a whole depended only on 6, we used reflection with a TODO comment > to clean it up when requiring the newer Java level. > >> add tests relying on modules detached from Java 11 > > I am not sure what this means, could you elaborate? > >> I prefer to keep the code ready to such requirements > > My preference was to keep the source structure as simple as possible > and make it more complex only if and when there is a demonstrated need > that cannot be solved in a simpler way. If that ever happens, we have > Git history to serve as a working example. > > Any third opinions? > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3Jh6udHP2z1ndpKNjrRB8qzSgwgQDuC1yTczNvMXjWiA%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/57BB7C5A-656D-453A-B643-2BD137DA10E2%40cloudbees.com. For more options, visit https://groups.google.com/d/optout.
