So according to you, discarding of workspaces when builds are discarded is responsibility of 'external-workspace-manager'. And advanced Build Discarder should be notified to do the additional cleanup ? And one more thing, deleting of builds should be done advanced build discarder. So how that can be implemented in a better way? My idea is: Using RunListener extension point for communication and filter methods would be accessible in the plugin. And after configuring the filter methods, whenever required delete() method would be called and it would delete the build.
On Friday, 5 April 2019 00:11:02 UTC+5:30, Jesse Glick wrote: > > On Thu, Apr 4, 2019 at 2:22 PM Nisarg Shah <nissh...@gmail.com > <javascript:>> wrote: > > Here I want to delete builds,artifacts and workspaces created by > External Workspace Manager. > > Artifacts are normally deleted alongside a build. (Unless you are > using `artifact-manager-s3`, by design.) Unless I am missing > something, it is the responsibility of the > `external-workspace-manager` plugin to implement deletion of (unused?) > external workspaces when builds are deleted, and that is orthogonal to > your proposal. `RunListener.onDeleted` is simply the hook plugins > receive to notify them to do any additional cleanup they need to, > however they see fit. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/9984dd04-c0fb-4a35-b9dc-eb37ab533e20%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
