> On 5. Apr 2019, at 08:20, Oliver Gondža <[email protected]> wrote:
> 
> I am wondering, do we really want to invest so much energy to clearly label 
> clutter (stalled PRs) in both github and JIRA? The way I look at it is the PR 
> failed to deliver the fix for the issue in question but there might be others 
> created in the future - I is not clear to me what value is there in 
> forwarding this info to JIRA.
> 
> Not that I have any numbers at hand on how often such stalled PRs dies, 
> revives, or keep being stalled - I presume they just sit there until closed 
> more of then then not, but I am wondering if an efficient way to close such 
> PRs would not be a better time investment. We would get rid of what I see as 
> clutter rather then precisely label it for someone else to do something about 
> it later.

There is some value in maintaining a link between an issue and its PR 
especially if the PR is half-finished (or even more) and just abandoned. PRs 
and code review comments of one attempt can also inform the next. So I'm all 
for ensuring there's a PR link in Jira, and perhaps even a label.

That said, I'm not quite sure what the purpose of the status would be. The 
existence of a stalled PR alone does not have an intrinsic meaning, like that 
an issue just needs a minor push over the finish line, that the current 
assignee is no longer interested in it, or that there would be no reviewers 
able to process it. None of these would apply in all cases.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/3CEACF81-9DF1-4332-AEFD-0C665748276D%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.

Reply via email to