Interesting! Assuming your approach is robust I’d vote for just putting this directly in jdk-tool <https://github.com/jenkinsci/jdk-tool-plugin> (and then very visibly deprecating the existing installer for Oracle Java) and adding you as a maintainer. You might be able to reuse the platform <https://github.com/jenkinsci/jdk-tool-plugin/blob/fac56e02ac795d510575363fdc0383d363f3ca03/src/main/java/hudson/tools/JDKInstaller.java#L620-L663> and CPU <https://github.com/jenkinsci/jdk-tool-plugin/blob/fac56e02ac795d510575363fdc0383d363f3ca03/src/main/java/hudson/tools/JDKInstaller.java#L668-L729> detection that already exists in the plugin today, and even if you want to keep a separate plugin looking through that code could be useful.
> On May 3, 2019, at 16:20, Mads Mohr Christensen <[email protected]> wrote: > > As a fun project and because it might be useful I’ve been working on a JDK > installer plugin for installing OpenJDK from AdoptOpenJDK.net > <http://adoptopenjdk.net/>. > > It still needs some work in order to be released as an actual plugin but > perhaps someone would like to have a look now? > > https://github.com/hrmohr/adoptopenjdk-plugin > <https://github.com/hrmohr/adoptopenjdk-plugin> > https://github.com/hrmohr/crawler/tree/adoptopenjdk > <https://github.com/hrmohr/crawler/tree/adoptopenjdk> > > I need to finish error handling and I would like to write some tests as well. > > Especially the part where OS and CPU is detected is something I’m not really > sure about, but I would be happy to get any feedback that will improve this > plugin in order for it to be released. > > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <mailto:[email protected]>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/56A31800-AFEA-47B5-A886-BAC196E606BF%40gmail.com > > <https://groups.google.com/d/msgid/jenkinsci-dev/56A31800-AFEA-47B5-A886-BAC196E606BF%40gmail.com?utm_medium=email&utm_source=footer>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/0B883128-2581-4601-9FA6-FBBD32D6F3FC%40cloudbees.com. For more options, visit https://groups.google.com/d/optout.
