> On 3 May 2019, at 22.28, Devin Nusbaum <[email protected]> wrote: > > Interesting! Assuming your approach is robust I’d vote for just putting this > directly in jdk-tool <https://github.com/jenkinsci/jdk-tool-plugin> (and then > very visibly deprecating the existing installer for Oracle Java) and adding > you as a maintainer. You might be able to reuse the platform > <https://github.com/jenkinsci/jdk-tool-plugin/blob/fac56e02ac795d510575363fdc0383d363f3ca03/src/main/java/hudson/tools/JDKInstaller.java#L620-L663> > and CPU > <https://github.com/jenkinsci/jdk-tool-plugin/blob/fac56e02ac795d510575363fdc0383d363f3ca03/src/main/java/hudson/tools/JDKInstaller.java#L668-L729> > detection that already exists in the plugin today, and even if you want to > keep a separate plugin looking through that code could be useful.
The jdk-tool plugin contains a lot more complicated logic and I like to keep it simple. It’s executing the installer for Windows and MacOS while my plugin just unzips the archive. Also I think that the Oracle installer is stil useful. I used jdk-tool plugin as a heavy inspiration and I think my approach to platform detection is pretty much the same. The thing I’m most unsure of are the actual values for “os.name” and “os.arch” for the additional platforms supported by AdoptOpenJDK and how I test it without having access to any of these platforms. I’ve been able to test the current version on Linux, MacOS and Windows and it looks good so far for these platforms. /M -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/922F4AE6-EFE6-4450-8EA3-7ABE2031BC65%40gmail.com. For more options, visit https://groups.google.com/d/optout.
