Hi Jesse, Our users are strongly asking for a better support of PR status update by SonarQube/SonarCloud when build is triggered by Jenkins. We don't like the try-fail strategy (trying to annotate current commit, then fallback on parent). Would you be ok to accept a contribution from SonarSource where we would add a new env variable (like CHANGE_COMMIT) to expose the PR head commit sha to the pipeline? We are interested to support both GitHub and Bitbucket, so we would ensure it works at least for those 2 plugins.
++ Julien Le mercredi 5 juin 2019 18:11:17 UTC+2, Jesse Glick a écrit : > > On Wed, Jun 5, 2019 at 11:06 AM Julien HENRY > <[email protected] <javascript:>> wrote: > > > https://github.com/deis/workflow-cli/blob/a285f6914f10ce81d0afe5d53603aa36cda78ccd/Jenkinsfile#L67 > > > That particular implementation is wrong anyway, since the PR head > commit might happen to be a merge commit, for example by a developer > resolving conflicts with the base branch. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/b5024d40-f47d-4893-b225-4593e984dc00%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
