Hi Jesse, Here are 3 PRs to implement the proposed change. I did only Bitbucket so far, but if you confirm I'm on the good track, I will submit the same for GitHub (I have the changes locally, just haven't tested end-to-end). https://github.com/jenkinsci/scm-api-plugin/pull/71 https://github.com/jenkinsci/branch-api-plugin/pull/163 https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/206
I think having a JIRA ticket to refer would be great, should I create one? I'm open to discussion to improve the code, either on this thread or on PRs themselves. ++ Julien Henry | SonarSource Developer https://sonarsource.com Le jeu. 13 juin 2019 à 15:44, Jesse Glick <[email protected]> a écrit : > On Thu, Jun 13, 2019 at 8:53 AM Julien HENRY > <[email protected]> wrote: > > the GIT_COMMIT variable […] was not defined out of the box in my tests. > I had to get it from the return of the checkout step > > Yes, each `checkout` step in the build, of which there could be zero > or more, can return its own metadata. > > For a branch project (such as a build of a GH PR), > `BranchNameContributor` sets build-wide environment variables > corresponding to the revision associated with the build overall. This > is what you would get if you `checkout scm`. > > -- > You received this message because you are subscribed to a topic in the > Google Groups "Jenkins Developers" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/jenkinsci-dev/-ojqklsaKbw/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr2d5Uawmzr-ybfbFjL8jNorY03NZ2Gjc2uoi0YyFxT-Ww%40mail.gmail.com > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAD9wyxG5eSS35n3i96qYoyJ90eY1ETz4T4cXyphGw7OWU5zP6g%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
