This is good advice, I will follow it moving forward. FWIW, the title line of the PR description said that unit tests were *currently *being written for feature and the last comment made on it mentioned my intention to change the unit testing method with a set of rewrites.
On Thu, Jul 11, 2019 at 3:50 PM 'Gavin Mogan' via Jenkins Developers < [email protected]> wrote: > I've found its good practice to prefix/include "WIP" or "WORK IN PROGRESS" > in the title. > > Labels are only assignable by committers/triagers > > On Thu, Jul 11, 2019 at 12:46 PM martinda <[email protected]> > wrote: > >> For: >> >>> to tell him that PR#2 needed review and shouldn't have been merged >>> >> >> Are you able to assign a label to the PR? I have used labels like "do not >> merge" before. >> >> Martin >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/6180cc33-633e-4fb5-81c1-f6900de78898%40googlegroups.com >> <https://groups.google.com/d/msgid/jenkinsci-dev/6180cc33-633e-4fb5-81c1-f6900de78898%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > -- > You received this message because you are subscribed to a topic in the > Google Groups "Jenkins Developers" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/jenkinsci-dev/_kNEe9ggaW0/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DusFtXTEnat9ov6%3DyypqG_fxBt3%2BoxYQN57ooLOYR1EwOA%40mail.gmail.com > <https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DusFtXTEnat9ov6%3DyypqG_fxBt3%2BoxYQN57ooLOYR1EwOA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMSuSKRH7Ex14_dUDg5MSVTh4X%3DjaGYeiGsWxO1877iKW6CkNw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
