This is good advice, I will follow it moving forward. FWIW, the title line of the PR description said that unit tests were *currently *being written for feature and the last comment made on it mentioned my intention to change the unit testing method with a set of rewrites.
On Thursday, July 11, 2019 at 3:50:09 PM UTC-4, Gavin Mogan wrote: > > I've found its good practice to prefix/include "WIP" or "WORK IN PROGRESS" > in the title. > > Labels are only assignable by committers/triagers > > On Thu, Jul 11, 2019 at 12:46 PM martinda <[email protected] > <javascript:>> wrote: > >> For: >> >>> to tell him that PR#2 needed review and shouldn't have been merged >>> >> >> Are you able to assign a label to the PR? I have used labels like "do not >> merge" before. >> >> Martin >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/6180cc33-633e-4fb5-81c1-f6900de78898%40googlegroups.com >> >> <https://groups.google.com/d/msgid/jenkinsci-dev/6180cc33-633e-4fb5-81c1-f6900de78898%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1a614dbe-ed93-4150-bd50-c271bd13cba2%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
