Re: Guideline for upgrading plugin to JDK 9+

Damian Szczepanik Mon, 21 Oct 2019 14:40:39 -0700

Title: Re: Guideline for upgrading plugin to JDK 9+

That pom.xml was helpful.

I had to upgrade org.jenkins-ci.plugins:plugin what also upgrades property jenkins.version so I expect that some older Jenkins installations won't be able to see new version via plugin manager?

Damian

Here is an example on how to suppress those files:

https://github.com/jenkinsci/warnings-ng-plugin/blob/master/pom.xml#L922

Am 20.10.2019 um 23:37 schrieb Damian Szczepanik <[email protected]>:

Re: Guideline for upgrading plugin to JDK 9+
I think that's the second option:

[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (display-info) @ cucumber-reports ---
[INFO] Restricted to JDK 1.8 yet com.fasterxml.jackson.core:jackson-annotations:jar:2.10.0.pr2:compile contains module-info.class targeted to 53.0
[INFO] Restricted to JDK 1.8 yet com.fasterxml.jackson.core:jackson-databind:jar:2.10.0.pr2:compile contains module-info.class targeted to 53.0
[INFO] Restricted to JDK 1.8 yet com.fasterxml.jackson.core:jackson-core:jar:2.10.0.pr2:compile contains module-info.class targeted to 53.0
[INFO] Ignoring requireUpperBoundDeps in com.google.guava:guava
[WARNING] Rule 2: org.apache.maven.plugins.enforcer.EnforceBytecodeVersion failed with message:
Found Banned Dependency: com.fasterxml.jackson.core:jackson-annotations:jar:2.10.0.pr2
Found Banned Dependency: com.fasterxml.jackson.core:jackson-databind:jar:2.10.0.pr2
Found Banned Dependency: com.fasterxml.jackson.core:jackson-core:jar:2.10.0.pr2

but then how to skip this particular 'violation' in this dependency? Or maybe discard all such problems?

Damian

You should not change to JDK 9 if not absolutely necessary.

Did your dependency really change the API to JDK 9? Or did they just compile with JDK 9 and add a module information file which requires the increased class file level? Those files can be ignored in the pom...

Am 20.10.2019 um 23:16 schrieb Damian Szczepanik <[email protected]>:

Hi,

After upgrading some plugin dependencies I found that dependency is compiled against JDK 9 while my plugin still uses 8 - compilation has failed.

Is there any recommendation, guideline, best practices that guide about:

Should I upgrade the plugin to JDK 9+ or it's not mandatory because from SLA perspective Jenkins should be upgraded?
Jenkins does not support 9 so should I upgrade to 11 at least?
Is there any plugin that have been already upgraded and could be taken as good reference how to make it painless?
What I would loose? eg Jenkins with older JDK won't be able to install new version of my plugin

Damian

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/20bf28ca-34fa-4776-9946-d7c1e166cdcb%40googlegroups.com.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/UgQ9wznpybw/unsubscribe.
To unsubscribe from this group and all its topics, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1021736F-D106-4C86-8FA5-91F3C2074ACF%40gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1131298390.20191020233750%40gmail.com.

Re: Guideline for upgrading plugin to JDK 9+

Reply via email to