I've had times when those groovy scripts "silently" fail on startup, and while isn't a big deal when I'm just restarting an existing instance, it does suck when I'm spinning up a new instance and suddely I don't have security setup.
I used to pair my jcasc config with my jenkins docker image, so I could roll back when things fail to start (I hit a helm bug and had to split them up again). I like the idea in that case of not being able to spin up a broken install. But I also understand that lots of people just tweak existing installs, and probably want warnings without fatals for parsing. So I really like that override behavior. I don't think the default should be warn though since it could potentially lead to insecure setups. On Thu, Jun 24, 2021 at 9:08 AM Tim Jacomb <[email protected]> wrote: > There are some flags you can use to tune this behaviour: > > https://github.com/jenkinsci/configuration-as-code-plugin/blob/a6983ff60e0cf198ce02d7992bcba927197174db/test-harness/src/test/resources/io/jenkins/plugins/casc/validSelfConfig.yml#L1-L5 > > The default is to show an error page with what failed. > > > I concur. My initial impression is that JCasC lacks polish, and I was > > surprised to see it promoted so heavily when issues like this remain. > > I think the consensus has been it's 'good enough', there's plenty of room > for improvement, but in general it works 'just fine' for most use-cases > > > > On Thu, 24 Jun 2021 at 16:54, Basil Crow <[email protected]> wrote: > >> On Thu, Jun 24, 2021 at 2:18 AM Ullrich Hafner <[email protected]> >> wrote: >> > This is a very bad user experience (actually I don’t know of any other >> application that does not start because of a configuration error). >> >> I concur. My initial impression is that JCasC lacks polish, and I was >> surprised to see it promoted so heavily when issues like this remain. >> >> > This is also the approach that we are using if a plugin changes >> serialization (or if a plugin cannot be started because of missing >> dependencies): in this case Jenkins still continues to work and the >> problems are highlighted in the UI. >> >> Core isn't entirely consistent in this regard, either. Yes >> OldDataMonitor and PluginWrapperAdministrativeMonitor exist. But I >> just tried corrupting core's config.xml file and Jenkins wouldn't >> start at all. But when I corrupted Email Extension's >> hudson.plugins.emailext.ExtendedEmailPublisher.xml, Jenkins started >> but with the default values for Email Extension and no administrative >> monitor in the UI. The latter clearly could use some improvement, but >> I'm not sure about the former. It seems that we want _some_ >> configuration loading errors to be fatal. But which ones, exactly? In >> the JCasC issue on GitHub, Antonio raised the valid point that errors >> in loading security-related configuration should be fatal (for obvious >> reasons). >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjrLf3jJ-dTk%2BOX1E4b2%3DvB2rsWDFgMX0%2BzKNHMbcgRcJA%40mail.gmail.com >> . >> > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BidoM3VfGS%2B4hiMs5dncaVywyrVm7OMt%3DZN6Yj%2BCTDwCyA%40mail.gmail.com > <https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BidoM3VfGS%2B4hiMs5dncaVywyrVm7OMt%3DZN6Yj%2BCTDwCyA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_Duvc4Ai%3D6PXbkTXgOkH4K%2BOU7FbLT5ZE7UR9Y%3Dzymxp%2Byw%40mail.gmail.com.
