On Thu, Jun 24, 2021 at 9:07 AM Tim Jacomb <[email protected]> wrote: > > There are some flags you can use to tune this behaviour: > https://github.com/jenkinsci/configuration-as-code-plugin/blob/a6983ff60e0cf198ce02d7992bcba927197174db/test-harness/src/test/resources/io/jenkins/plugins/casc/validSelfConfig.yml#L1-L5
Those flags don't work in all cases. Try the following JCasC YAML file when Theme Manager is installed but Dark Theme is not installed: configuration-as-code: version: 1 deprecated: warn restricted: warn unknown: warn unclassified: themeManager: disableUserThemes: false theme: "darkSystem" Jenkins will not start up. Now try starting Jenkins with a io.jenkins.plugins.thememanager.ThemeManagerPageDecorator.xml file that references io.jenkins.plugins.darktheme.DarkThemeSystemManagerFactory when Theme Manager is installed but Dark Theme is not installed. Jenkins does start up. (No warning is displayed and the default theme is used.) I think the ideal behavior in both cases would be for Jenkins to start up and display an administrative monitor warning that invalid configuration was not applied. (Obviously, this would not apply to security-related configuration per Antonio's point.) > I think the consensus has been it's 'good enough', there's plenty of room for > improvement, but in general it works 'just fine' for most use-cases I don't disagree. Yet I also recall listening to an interview with Kohsuke where he explicitly talked about wanting to build a tool that was not only good enough but also a pleasure to use. That seems like an example worth following. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjqSK-xxwCgTeOCKrviU2JSnce9OkXURcgtvURzMFf3Rag%40mail.gmail.com.
