On Tue, Apr 5, 2022 at 9:51 PM Mark Waite <[email protected]> wrote:
> I need further guidance on one plugin.
I took a look at your code and see that you are overriding the <argLine>
from the plugin parent POM in your plugin POM. This override is not
extending the original value but replacing it, just as overriding a method
in a subclass without calling super() in Java code would replace the
original method rather than extend it. As of 4.39 this meant that your
plugin was blanking out the -Xms, -Xmx, -XX:HeapDumpOnOutOfMemoryError,
-XX:TieredCompilation, and -XX:TieredStopAtLevel settings from the plugin
parent POM – incorrect, but harmless. As of 4.40, this means your plugin is
blanking out the @{jenkins.addOpens} and @{jenkins.insaneHook} settings
from the plugin parent POM – incorrect, and harmful when running on Java 17.
I suggest either removing your override of <argLine> (recommended, if
possible) or changing it so that it extends the setting from the plugin
parent POM rather than replacing it. Since your plugin was in error before
the release of plugin parent POM 4.40, I am not going to update the plugin
parent POM 4.40 release notes.
The <argLine> interface exposed by the plugin parent POM is not ideal, and
this mistake is particularly easy to make. The interface could be cleaned
up by introducing a property with default JVM settings that you could
override, but since this is a pre-existing issue that I am making neither
better nor worse with recent changes, I have no plans to work on it.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjqy18JSSA4wbRH8kejVFgn2mjqHZ--xdLmdX5cQ52ODtA%40mail.gmail.com.
