First of all, huge thank you to Tim for working on this effort! +1 from me. I think a consistent and automatically applied set of formatting rules will make it easier to read and edit these files in the future.
The most significant objections I have heard so far were that Prettier poorly formats "if" statements without braces and that applying any kind of formatting change will make security backports more difficult. The first of these is being addressed systematically in https://github.com/jenkinsci/jenkins/pull/6974 by preformatting the codebase to add curly braces everywhere, and I understand that Tim plans to address the second objection by backporting the formatting change to all active branches. I can also volunteer to help address merge conflicts that arise from the integration of this change, if that would be helpful. Two other objections were raised: line length and the removal of unnecessary parentheses around arithmetic expressions. These are subjective preferences, and one of the reasons to adopt autoformatting is to eliminate debate around such subjective preferences in order to focus collaboration on content (logic) rather than presentation (formatting). In other words, I acknowledge these objections, but in my opinion the benefit (being able to effortlessly read and write code without worrying about formatting) is worth the cost (giving up control over some subjective preferences for the sake of cohesion). -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjp-b3bg%2BtNJhJuGFnUBEQCTrEobciJzyjjDoQ_5G5T0%2Bw%40mail.gmail.com.
