We have eslint as well to do things like what you said My preference is for opinionated formatters so we don’t have to worry about debating options and it does a really good job by just automatically formatting it, you don’t get red lines in your IDE as you type distracting you like you do with eslint if you’re using it for formatting, as the expectation is you run the format before committing
Places where the formatted is doing some we really don’t want can have an ignore comment added to it On Sat, 13 Aug 2022 at 05:59, 'Gavin Mogan' via Jenkins Developers < [email protected]> wrote: > I know i said I had issues with prettier being opinionated, but my > issue wasn't the opinions it had, just that it wasn't very flexible. > My personal projects I usually import one of the opinionated rulesets > to eslint and have it done, but eslint is infinitely configurable, > while my experience, at least when I last used it, prettier was > frustrating to manage. I'm all about tooling being opinionated. > > So absolutely not against prettier, just more of a "have you look at > eslint instead? it also has the ability to keep an eye on other things > like using undefined variables" > > On Tue, Aug 9, 2022 at 3:31 PM Basil Crow <[email protected]> wrote: > > > > On Tue, Aug 9, 2022 at 2:46 AM '[email protected]' via Jenkins > Developers <[email protected]> wrote: > > > > > > I think it's the key point about the complaints again Prettier, it's a > very > > > opinionated, meaning that it's not about our subjectivity, but reusing > the > > > one from its author. There is no truth about what must be done or not > around > > > this kind of style, hence the desire to have this discussion, to find a > > > consensus about the "community subjectivity" instead of relying on > someone > > > else['s] opinion. > > > > Please read my previous post about this topic if you have not already. > Ceding control of some subjective preferences to an opinionated tool with > few (if any) configuration options can be uncomfortable at first, but in my > experience the benefits outweigh the disadvantages in the long term. These > benefits include never having to deal with a PR that includes a mix of > formatting and logic changes (faster code reviews), being able to write > code more quickly without having to make formatting decisions, and being > able to read code more easily when it is all written in a consistent style. > > > > I have implemented automatic formatting in large organizations many > times in my career, and in all cases people complained a little at first > but then grew to like it. I myself disliked some of the opinions of the > authors of the tools I was putting in place, but putting my own advice into > practice I decided to set aside my own opinions for the sake of group > cohesion and the benefits described above. > > > > -- > > You received this message because you are subscribed to the Google > Groups "Jenkins Developers" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to [email protected]. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjpz6ieWaXWQx8coavENczXDTDTkr3ei7dq86Q4XdXZrgw%40mail.gmail.com > . > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DuvtX1pat5VdtsoN7QrLa%2BTfbDr%2B8u0DFxpGwP3%2BCQXHqg%40mail.gmail.com > . > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3Bif%2BmVBMFrUdTecV%2Bb-E7pa5CeNMMjWpWjjg1QWALKVF4w%40mail.gmail.com.
