|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.
Digging through source code
Crap4J returns false on failure https://svn.jenkins-ci.org/trunk/hudson/plugins/crap4j/src/main/java/hudson/plugins/crap4j/Crap4JPublisher.java
if (0 == reports.length) { log(logger, "No crap4j report files were found. Configuration error?"); return false; }
Where xUnit returns true and sets the build result to failure
https://github.com/jenkinsci/xunit-plugin/blob/a0ad57db81ef5a91162dbfa7190a1a8bcb838edd/src/main/java/org/jenkinsci/plugins/xunit/XUnitProcessor.java#L83
GitPublisher is looking at the build result:
https://github.com/jenkinsci/git-plugin/blob/cebb9da131fa6c9e07ec9e6ff71ec89aa58fdd6f/src/main/java/hudson/plugins/git/GitPublisher.java#L203
Theoretically the false result is canContinue:
https://github.com/jenkinsci/jenkins/blob/a197999c6c57ad761f7242b9f6b28c0333175601/core/src/main/java/hudson/model/AbstractBuild.java#L781
But in actuality all build steps run even if one fails (though a final result of false is reported):
https://github.com/jenkinsci/jenkins/blob/a197999c6c57ad761f7242b9f6b28c0333175601/core/src/main/java/hudson/model/AbstractBuild.java#L724
It looks like their is absolutely no way that git-publish could know that Crap4J failed unless Crap4J changes the build result like all the other plugins.
Thanks for your help in testing things and helping me narrow this to a point that I could find the actual problem.
I'll reference this in a Crap4J bug. I would try to fix it since it should be a one line change, but that plugin is still on an old SVN structure, and I'm not familiar with building Jenkins plugins from scratch.