|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.
Let's try to solve this, I don't like to pin versions of plugins.
Digging a little into the code (I'm no Java-dev), I think that no comments will be made if the comments set in the configs are set to "".
It seesm that the setting "Use comments to report results when updating commit status fails" or "Published Jenkins URL" is not honored. I have set useComments to false and the publishURL is empty. I confirmed in the WebUI and in the config-xml.
would changing https://github.com/jenkinsci/ghprb-plugin/blob/7cf87d0fa7a14ee52c4b63dc341c43a75c4d1825/src/main/java/org/jenkinsci/plugins/ghprb/GhprbBuilds.java#L192-L195 be the right thing to do?
I could try to create a pullrequest on github, but I don't know the correct way of asking for those config settings.
What do you think?