Sorry, I misspoke about this. The email-ext plugin uses ChangeSet.Entry.getAuthor(), depending on the SCM plugin you are using, it can do lookups like I mentioned. The Git plugin will try and do the resolution of username -> email using the mail resolver from the Mailer plugin (which is where the extension point lives). I was confusing where the resolver was in the infrastructure. The TL;DR is that it is still the MailResolver feature that is taking the time, but the sequence was different than I remembered.
On Mon, Apr 27, 2020 at 10:42 AM Slide <[email protected]> wrote: > That sounds like the culprit to me. Email-ext has to resolve usernames > from the changeset so an email address. It provides an extension point for > this that other plugins can implement to provide that service. If you are > having long delays accessing LDAP, that would definitely point to that as a > culprit for the length of time. > > On Mon, Apr 27, 2020 at 7:37 AM Sverre Moe <[email protected]> wrote: > >> Our Jenkins have enabled Login with LDAP. >> >> We do occasionally experience LDAP timeout also. 60 seconds timeout. >> Perhaps there is a relation to that, considering that each author found >> by emailextrecipients also takes 60 seconds each. >> >> mandag 27. april 2020 16.25.37 UTC+2 skrev slide følgende: >>> >>> There is no lookup until the email is sent. There may be a call to >>> resolve a username to the email address though. Are you using ldap or AD? >>> >>> On Mon, Apr 27, 2020, 01:39 Sverre Moe <[email protected]> wrote: >>> >>>> Well at this point I am not sending any email, yet. >>>> I am looking up recipients from change set, so I can use that later >>>> when/if I send email for failed builds. >>>> >>>> Does emailextrecipients do the lookup itself, or is it done when >>>> calling mail step? >>>> >>>> mandag 27. april 2020 01.12.48 UTC+2 skrev Jeremy Mordkoff følgende: >>>>> >>>>> sending email always involves a forward lookup and many mail servers >>>>> do a reverse lookup on the sender's IP. >>>>> >>>>> >>>>> >>>>> *--- Jeremy Mordkoff* >>>>> Director of Engineering Services >>>>> <https://www.riftio.com> >>>>> RIFT, inc >>>>> 900 Chelmsford Street, 4th floor, tower 3 >>>>> Lowell, MA 01851 >>>>> 1.978.257.2183 (*cell*) >>>>> <http://www.riftio.com>www.riftio.com >>>>> ------------------------------ >>>>> *From:* [email protected] <[email protected]> on >>>>> behalf of Sverre Moe <[email protected]> >>>>> *Sent:* Sunday, April 26, 2020 3:32 PM >>>>> *To:* Jenkins Users <[email protected]> >>>>> *Subject:* Re: The pipeline emailextrecipients step takes too long >>>>> time >>>>> >>>>> How so? >>>>> >>>>> Does emailextrecipient do a DNS lookup on each author it can find? >>>>> >>>>> søndag 26. april 2020 20.12.03 UTC+2 skrev jeremy mordkoff følgende: >>>>> >>>>> check that DNS is working. I've seen huge delays on basic ops when DNS >>>>> lookups are timing out. Check forward and reverse lookups. >>>>> >>>>> >>>>> >>>>> On Sunday, April 26, 2020 at 12:30:59 PM UTC-4, slide wrote: >>>>> >>>>> Can you add timestamps? It's hard to tell from what you posted when >>>>> things are occurring. >>>>> >>>>> On Sun, Apr 26, 2020, 01:16 Sverre Moe <[email protected]> wrote: >>>>> >>>>> Yes it did. >>>>> >>>>> Just one simple little commit, and Checkout took a little over 1 minute >>>>> >>>>> [Pipeline] emailextrecipients >>>>> <https://build-ci.spacetec.no:8443/view/All%20meosconfig/job/meosconfig-dashboard-layouts/job/master/168/console#> >>>>> Collecting change authors... >>>>> build: 168 >>>>> adding author: Sverre Moe >>>>> >>>>> Adding Sverre Moe with address [email protected] >>>>> Analyzing: [email protected] >>>>> Looking for: [email protected] >>>>> starting at: 0 >>>>> firstFoundIdx: 0 >>>>> firstFoundIdx-substring: [email protected] >>>>> => found type: 0 >>>>> Analyzing: [email protected] >>>>> Looking for: [email protected] >>>>> starting at: 0 >>>>> firstFoundIdx: 0 >>>>> firstFoundIdx-substring: [email protected] >>>>> => found type: 0 >>>>> Analyzing: [email protected] >>>>> Looking for: [email protected] >>>>> starting at: 0 >>>>> firstFoundIdx: 0 >>>>> firstFoundIdx-substring: [email protected] >>>>> => found type: 0 >>>>> >>>>> >>>>> lørdag 25. april 2020 21.51.25 UTC+2 skrev slide følgende: >>>>> >>>>> I think the debug logs will just go to the build log. >>>>> >>>>> On Sat, Apr 25, 2020, 11:58 Sverre Moe <[email protected]> wrote: >>>>> >>>>> Tried to configure debug >>>>> Manage Jenkins > Configure System > Extended Email Notification >>>>> >Enable Debug >>>>> >>>>> I added a System Log for "hudson.plugins.emailext" and Log Level ALL. >>>>> >>>>> Hope I can find something about why it takes so long. >>>>> >>>>> fredag 24. april 2020 23.20.40 UTC+2 skrev slide følgende: >>>>> >>>>> You can turn on debug mode in the global config for Email Ext. The >>>>> code isn't really doing anything major, it just looks at the changesets >>>>> and >>>>> get the authors, so I am not sure why it would be taking that long. >>>>> >>>>> On Fri, Apr 24, 2020 at 1:59 PM Sverre Moe <[email protected]> wrote: >>>>> >>>>> Calling the pipeline step emailextrecipients when there are changes >>>>> takes too much time. >>>>> A normal git checkout that takes 10-15 seconds, will usually take 1-2 >>>>> minutes when there are changes, just because of emailextrecipients. >>>>> All I want is the authors from the current build changes. I see no >>>>> reason why this should take so long. >>>>> >>>>> I took a small look at the code for emailextrecipients, and it seems >>>>> it looks also on previous builds. >>>>> >>>>> def recipients = emailextrecipients([developers()]) >>>>> >>>>> Our developers want the builds to run as fast as it can. Time is >>>>> precious. >>>>> I am considering removing this recipients. I already have the git >>>>> repository maintainers I can send email notifications to if anything goes >>>>> wrong. >>>>> The backside of removing this, is I cannot send email notifications >>>>> for the developers, just the maintainers (and those only want >>>>> notifications >>>>> for release build, and not all continuous builds). >>>>> >>>>> The reason I call emailextrecipients during the Checkout stage, is >>>>> because that is the only stage where I have access to the git repository. >>>>> Later in the build if it fails I do not have access to git anymore. >>>>> >>>>> The emailextrecipients code does have some Debug logging. How can I >>>>> enable this to see what it is actually doing? >>>>> >>>>> I was thinking of implementing my own parsing of the change records. >>>>> It cannot possibly take more than a few seconds to find the authors of all >>>>> the changes. >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Jenkins Users" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/jenkinsci-users/de0f53c9-9512-4fd6-a258-e604412ff77a%40googlegroups.com >>>>> <https://groups.google.com/d/msgid/jenkinsci-users/de0f53c9-9512-4fd6-a258-e604412ff77a%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>>> >>>>> >>>>> -- >>>>> Website: http://earl-of-code.com >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Jenkins Users" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/jenkinsci-users/fbf04c99-b61b-4109-ac21-50a77fca08c0%40googlegroups.com >>>>> <https://groups.google.com/d/msgid/jenkinsci-users/fbf04c99-b61b-4109-ac21-50a77fca08c0%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Jenkins Users" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/jenkinsci-users/d96643c8-b4d1-46bc-9339-c5094dd2d3c7%40googlegroups.com >>>>> <https://groups.google.com/d/msgid/jenkinsci-users/d96643c8-b4d1-46bc-9339-c5094dd2d3c7%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>>> -- >>>>> You received this message because you are subscribed to a topic in the >>>>> Google Groups "Jenkins Users" group. >>>>> To unsubscribe from this topic, visit >>>>> https://groups.google.com/d/topic/jenkinsci-users/JvBIc0_EXsg/unsubscribe >>>>> . >>>>> To unsubscribe from this group and all its topics, send an email to >>>>> [email protected]. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/jenkinsci-users/c30c15e2-6aa8-4016-a27e-c4711607642b%40googlegroups.com >>>>> <https://groups.google.com/d/msgid/jenkinsci-users/c30c15e2-6aa8-4016-a27e-c4711607642b%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Jenkins Users" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/jenkinsci-users/3ea8d7eb-4b22-48ca-9f05-5f7fcc86d0d8%40googlegroups.com >>>> <https://groups.google.com/d/msgid/jenkinsci-users/3ea8d7eb-4b22-48ca-9f05-5f7fcc86d0d8%40googlegroups.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Users" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-users/e7aa49cb-cf0a-4fd1-8d52-547e54ea6e6c%40googlegroups.com >> <https://groups.google.com/d/msgid/jenkinsci-users/e7aa49cb-cf0a-4fd1-8d52-547e54ea6e6c%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > > > -- > Website: http://earl-of-code.com > -- Website: http://earl-of-code.com -- You received this message because you are subscribed to the Google Groups "Jenkins Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/CAPiUgVfBxj9GJjjM_PeqE3TQMLuWzZrHeDctNw9pvvaCaWTw-A%40mail.gmail.com.
