Massimiliano,
I attempted to build the ChangeLanguage portlet and the associated
localization service that you sent us a while back.
It had syntax errors and wouldn't compile.
Please compile your code before submitting it to the list.
if (user=="null")
where user is a JetspeedUser. Which Java compiler are you using?
Please don't dump code on us and expect the committers to clean up after
you.
After cleaning the syntax errors, I found:
The ConstructorHtml class needed cleaning up, it wasn't handling
JetspeedLinks correctly. (see the cvs head)
It could still use a lot of improvement. Don't recommend hard-coding HTML
into Java code, better to use Velocity or JSP.
These two params are passed in, but are not used:
String linguaAttuale, String linguaRichiesta
Please review the Java coding standards on the Jetspeed website.
Make sure that it passes CheckStyle. Use 4 space tabs.
When is the service used? I thought it would be called by the portlet
somehow. Perhaps its just not obvious to me.
As for the functionality, what is it supposed to do?
I thought it would immediately change the language on the fly....
I guess I'll check it in, I think it could be useful if you are willing to
clean it up and submit patches, I'll work with you on it.
David
--
To unsubscribe, e-mail: <mailto:jetspeed-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail: <mailto:jetspeed-dev-help@;jakarta.apache.org>
