> -----Original Message-----
> From: Glen Carl [mailto:[EMAIL PROTECTED]]
> Sent: Monday, November 25, 2002 7:12 PM
> To: Jetspeed Developers List
> Subject: default skin change in JetspeedPortalkitServices.java
>
>
> I noticed a change to
> /services/portaltoolkit/JetspeedPortalToolkitService that I would like
> to express a preference for.
>
> Rather than getting the default.skin from jr.props, I liked it when the
> skin==null would get the parent skin. The reason being, it allows for an
> easy change to velocity templates to get whole pane sections to be one
> color. My current client, only wants to select skin in one location and
> have the skin theme applied to the entire portlet experience (much like
> my.yahoo does it). I see the reason for your change, but I wonder if the
> community has a whole has preference?
I've been going through the feature set in the JRP and testing it out. It looked like
a bug when changing the global setting had no effect.
I really didn't realize that I broke another feature. Sorry.
The change was what I perceived to be a bugfix.
I have no other reason for making this change.
Perhaps there should be a fallback algorithm:
- first check the current portlet(set), if no skin then
- fallback to its parent, if no skin then
- fallback to global setting
>
> The beauty of open source is I can make the adjustment to fit my needs.
You have the source, subclass and plug in a new toolkit service.
Regarding the core code, first consider what is best for the community, not whats best
for someone's current client.
David
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
