default skin change in JetspeedPortalkitServices.java

[Glen Carl]

I noticed a change to /services/portaltoolkit/JetspeedPortalToolkitService that I would like to express a preference for.

Rather than getting the default.skin from jr.props, I liked it when the skin==null would get the parent skin. The reason being, it allows for an easy change to velocity templates to get whole pane sections to be one color. My current client, only wants to select skin in one location and have the skin theme applied to the entire portlet experience (much like my.yahoo does it). I see the reason for your change, but I wonder if the community has a whole has preference?

The beauty of open source is I can make the adjustment to fit my needs.
Thanks,
Glen


---

- * @version $Id: JetspeedPortalToolkitService.java,v 1.23 2002/11/08 10:05:18 raphael Exp $
+ * @version $Id: JetspeedPortalToolkitService.java,v 1.25 2002/11/20 16:32:38 taylor Exp $
*/
public class JetspeedPortalToolkitService extends TurbineBaseService
implements PortalToolkitService
@@ -116,7 +116,6 @@
this.defaultControl = serviceConf.getString("default.control");
this.defaultController = serviceConf.getString("default.controller");
this.defaultSkin = serviceConf.getString("default.skin");
-
setInit(true);

}
@@ -535,6 +534,10 @@
if (portlets.getSkin()!=null)
{
pc.setPortletSkin( getSkin( portlets.getSkin() ) );
+ }
+ else
+ {
+ pc.setPortletSkin( getSkin( this.defaultSkin ) );
}


--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>