Glen, If you don't mind me asking, what is the suggested approach as the bugzilla has no information regarding a proposed solution? I apologize if this has already been posted to dev, but I haven't been lurking as of late.
Thanks, Scott > -----Original Message----- > From: Glen Carl [mailto:[EMAIL PROTECTED]] > Sent: Tuesday, December 31, 2002 1:25 PM > To: Jetspeed Developers List > Subject: Re: [PATCH] Root portlet set's skin not recognized by children > > I noticed this problem, and bug 14909 was submitted for this problem. > David Sean Taylor was looking at my proposed change, and was going to > follow up on Jan. 6. Please look at bug 14909. > Thanks, > Glen > > protected PortletConfig getPortletConfig( Portlets portlets ) > > if (portlets.getSkin()!=null) > > { > > pc.setPortletSkin( getSkin( portlets.getSkin() ) ); > > } > > - else > > - { > > - pc.setPortletSkin( getSkin( this.defaultSkin ) ); > > - } > > Weaver, Scott wrote: > > I don't know if it is just me, but children, without skin definitions, > > under the root portlet set where not recognizing the root portlet set's > > skin and using the system default instead. > > > > This is against the CVS HEAD from yesterday. > > > > Scott > > > > > > > > > > ------------------------------------------------------------------------ > > > > Index: JetspeedPortalToolkitService.java > > =================================================================== > > RCS file: /home/cvspublic/jakarta- > jetspeed/src/java/org/apache/jetspeed/services/portaltoolkit/JetspeedPorta > lToolkitService.java,v > > retrieving revision 1.25 > > diff -u -r1.25 JetspeedPortalToolkitService.java > > --- JetspeedPortalToolkitService.java 20 Nov 2002 16:32:38 -0000 1.25 > > +++ JetspeedPortalToolkitService.java 31 Dec 2002 14:59:01 -0000 > > @@ -429,6 +429,13 @@ > > for (Iterator it = portlets.getPortletsIterator(); > it.hasNext(); ) > > { > > Portlets subset = (Portlets)it.next(); > > + // STW: Fixes the issue of the root Portlet Sets skin > > + // not being recognized by children with undefined skins. > > + if(portlets.getSkin() != null && subset.getSkin() == null) > > + { > > + subset.setSkin(portlets.getSkin()); > > + } > > + > > Map constraints = getParameters(subset.getLayout()); > > int position = getPosition( subset.getLayout() ); > > set.addPortlet( getSet( subset, theCount ), > > > > > > > > ------------------------------------------------------------------------ > > > > -- > > To unsubscribe, e-mail: <mailto:jetspeed-dev- > [EMAIL PROTECTED]> > > For additional commands, e-mail: <mailto:jetspeed-dev- > [EMAIL PROTECTED]> > > > -- > To unsubscribe, e-mail: <mailto:jetspeed-dev- > [EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:jetspeed-dev- > [EMAIL PROTECTED]>
