Re: [PATCH] Root portlet set's skin not recognized by children

[Glen Carl]

Scott,
Below is info from bugzilla, my proposed fix and my test results on Dec. 16, 2002. However, Dec. 26, 2002 David said test case 1 did not work with my proposed fix. I have not had a chance to verify. It is possible your fix is better, and you may want to run through the test cases to verify the algorithm matches what is specified in bugzilla.
Thanks,
Glen

From bugzilla bug 14909,
When resolving the skin to use on a portlet, the skin is found using the global setting, but doesn't check the parent. The algorithm should:
- first check the current portlet(set), if no skin then
- fallback to its parent, if no skin then
- fallback to global setting

proposed changes to fix issue with portlet skin use.
/services/portaltoolkit/JetspeedPortalToolkitService.java
protected PortletConfig getPortletConfig( Portlets portlets )
if (portlets.getSkin()!=null)
{
pc.setPortletSkin( getSkin( portlets.getSkin() ) );
}
remove else
remove {
remove pc.setPortletSkin( getSkin( this.defaultSkin ) );
remove }


I ran the following tests.
>
> 1) no skin ref in PSML
> RESULT: uses default skin
>
> 2) skin set a top level, no skin setting for children portlets
> RESULT: children portlets use the top level skin setting
>
> 3) skin set at top level, and skin set in child portlet
> RESULT: uses skin assigned for child portlet
>
> 4) no skin at top level, and skin set in child portlet
> RESULT: uses skin assigned for child portlet, and all other portlets use
> default


--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>