On Thu, 2004-07-01 at 12:07, David Sean Taylor wrote: > On Jul 1, 2004, at 8:35 AM, Scott T Weaver wrote: > > > PortletWindowAccessor has 2 methods: createPortletWindow methods that > > are never used anywhere, looks like the getWindow methods take care of > > this for us automatically. I propose we delete these unused methods as > > they can cause confusion on how the API is used. > > > > -1 > I think you need to do a CVS update now and then and be considerate of I update every day. I don't use J1 so I don't have it in my environment, I guess that is on more thing I need to be concerned about. > what other developers on the TEAM are doing That is why I asked. I could have just deleted them.
> > Removing createPortletWindow(PortletEntity, String) will break the build > See org.apache.jetspeed.fusion.portal.portlets.JetspeedFusionPortlet in > the Jetspeed CVS > > The second signature createPortletWindow(String) may be deleted, > although you may want to check with Serge, > he currently uses the first signature also > > > > > We may also want to be on the look out for such unused methods in other > > classes. > > > Why don't you create an issue: "Review and Document Jetspeed API", > there are lots of interfaces and methods without documentation found > under components > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
