Joshua Lucas wrote:
>
> Sorry for the length of this mail but everything here seems to be
> flowing together.
>
> For the past few days, I've been working with the CocoonPorlet. I've
> noticed a few things which I'd like to bring to the list's attention.
>
> 1) Since JetSpeed doesn't *know* the content of the xml retrieved when
> the CocoonPorlet is used, as opposed to the RSSPortlet where Castor does
> its magic, I'm proposing that the CP(CocoonPortlet) use the <metainfo>
> element for its title and description.
Yeah. By default the getTitle and getDescription that are in
AbstractPortlet check the meta info. I will tweak your patch to look
there first.
> 2) I've added an additional getPI() method which takes the RunData as a
> parameter. This is because when you click 'Edit,' the CP can't find the
> stylesheet parameter because the info is being passed along so the xml
> is just displayed as a mass of text. This new method is called during
> the getContent() process. If the initial getPI() returns null, we call
> getPI(rundata) to see if the info is being passed through a Query
> string.
>
> 3) To support #2, I changed the way the DefaultPorletControl creates
> the 'Edit' link so that it also includes the parameters for the portlet.
Cool. We might also want to think about using GUIDs so that portlets
can have PK that you reference them by.
> 4) Back to the CocoonPorlet, I commented out the call to the
> PersistentDocument within getPI() as I don't see the need for it nor was
> it working. Once commented out, it worked. I'll keep looking into that
> one.
will take a look.
> I think that's it but feel free to ping me with any questions. Also, is
> there a plan for the cvs commits to be mailed to the list? That would
> be cool and helpful.
<snip>
Thanks for the code!
--
Kevin A Burton
http://relativity.yi.org
Message to SUN: "Open Source Java!"
"For evil to win is for good men to do nothing."
--
--------------------------------------------------------------
Please read the FAQ! <http://java.apache.org/faq/>
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Archives and Other: <http://java.apache.org/main/mail.html>
Problems?: [EMAIL PROTECTED]
