----- Original Message -----
From: Kevin A. Burton <[EMAIL PROTECTED]>
To: JetSpeed <[EMAIL PROTECTED]>
Sent: Wednesday, February 23, 2000 1:29 PM
Subject: Re: Possible patches and some thoughts
> Joshua Lucas wrote:
> >
> > Sorry for the length of this mail but everything here seems to be
> > flowing together.
> >
> > For the past few days, I've been working with the CocoonPorlet. I've
> > noticed a few things which I'd like to bring to the list's attention.
> >
> > 1) Since JetSpeed doesn't *know* the content of the xml retrieved when
> > the CocoonPorlet is used, as opposed to the RSSPortlet where Castor does
> > its magic, I'm proposing that the CP(CocoonPortlet) use the <metainfo>
> > element for its title and description.
> >
> > 2) I've added an additional getPI() method which takes the RunData as a
> > parameter. This is because when you click 'Edit,' the CP can't find the
> > stylesheet parameter because the info is being passed along so the xml
> > is just displayed as a mass of text. This new method is called during
> > the getContent() process. If the initial getPI() returns null, we call
> > getPI(rundata) to see if the info is being passed through a Query
> > string.
> >
> > 3) To support #2, I changed the way the DefaultPorletControl creates
> > the 'Edit' link so that it also includes the parameters for the portlet.
> >
> > 4) Back to the CocoonPorlet, I commented out the call to the
> > PersistentDocument within getPI() as I don't see the need for it nor was
> > it working. Once commented out, it worked. I'll keep looking into that
> > one.
> >
> > I think that's it but feel free to ping me with any questions. Also, is
> > there a plan for the cvs commits to be mailed to the list? That would
> > be cool and helpful.
> <snip>
>
> This is DONE and in CVS.
>
Cool! I still have an issue with the CocoonPortlet though.
I don't believe we should be throwing a PortletException within getPI().
The String style can be null which is why the additional getPI(Rundata
rundata) method was created.
I would say we take out the check for null as well as the PersistentDocument
lookup. I believe this was in the patch I sent earlier but if not, I'll
send you another one if you need it.
josh
--
--------------------------------------------------------------
Please read the FAQ! <http://java.apache.org/faq/>
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Archives and Other: <http://java.apache.org/main/mail.html>
Problems?: [EMAIL PROTECTED]
