Jon Stevens wrote:
> on 11/1/2000 4:06 PM, "Santiago Gala" <[EMAIL PROTECTED]> wrote:
>
> > It is initialized upon construction from ServerData's, which in turns takes it
> > from the request.
> > Nevertheless, it is never used (apart from having a getter and a setter) in
> > DynamicURI. When printing
> > the URL, the script name is taken from the ServerData object directly.
> >
> > I wonder if it is not redundant in Turbine's RunData. It is misleading to have
> > it there, with a getter
> > and a setter, and not using it to generate the URL at the end.
> >
> > BTW, I have been looking quite carefully to the class without noticing before.
> > Only now, following the
> > track of the var, did I notice about it.
> >
> > I think it should be fixed. What do you think, Jon?
>
> What the heck are you talking about? What should be fixed?
>
> :-)
>
Sorry for my unability to express myself.
In DynamicURI.java The instance var
scriptName.
It has a getter and a setter, and it is initialized from ServerData, but it is not
used to produce the URL text. Instead,
output.append ( data.getServerData().getScriptName() ); is used.
So, the var seems redundant, and dangerous, as a user could think that by setting it
it will achieve some effect. So it should be taken out, or substituting the line
above by
output.append ( scriptName ); is used.
>
> -jon
>
> --
> http://scarab.tigris.org/ | http://noodle.tigris.org/
> http://java.apache.org/ | http://java.apache.org/turbine/
> http://www.working-dogs.com/ | http://jakarta.apache.org/velocity/
> http://www.collab.net/ | http://www.sourcexchange.com/
>
> --
> --------------------------------------------------------------
> Please read the FAQ! <http://java.apache.org/faq/>
> To subscribe: [EMAIL PROTECTED]
> To unsubscribe: [EMAIL PROTECTED]
> Archives and Other: <http://java.apache.org/main/mail.html>
> Problems?: [EMAIL PROTECTED]
--
--------------------------------------------------------------
Please read the FAQ! <http://java.apache.org/faq/>
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Archives and Other: <http://java.apache.org/main/mail.html>
Problems?: [EMAIL PROTECTED]
