on 1/29/01 11:40 AM, "David Sean Taylor" <[EMAIL PROTECTED]>
wrote:
> Wow, the wrath of Jon, bummer...
Not wrath. I put a friggen :-) at the end of the email. Sigh.
:-(
> Let me *try* to defend myself:
>
> In creating JetspeedPersistenceService.java, I copied
> PersistenceServiceImpl.java.
> The code is basically the same, but the JetspeedPersistenceService uses a
> newer profiler.
> I didn't want to modify PersistenceServiceImpl.java, since others may still
> want to use the old profiler. Thus I created a new service impl.
Not a problem.
> I will change the variable names.
Great!
> I have also brought up the fact on this mailing list that invocations of the
> Persistence Service required multiple 'new' persistence services per
> request.
> So this means that since the lifetime of the service object is only for one
> request, its then safe to 'cache' the RunData, since the service object will
> be gone after the request.
Ok. I was just checking.
> This is counter to how I believe services should work, again I've discussed
> this on the list.
Then maybe implement it differently?
> In defense of the authors, I believe that the PersistenceService was written
> as a 'temporary solution', since the underlying classes used by it i.e. the
> PortletSet and PSMLManager are due for some major overhauls. In that spirit,
> I left the service as is since it works for now.
>
> Im all for rewriting the Persistence Service to be a Turbine Service. But
> when I suggested that, it was argued that we are considering our own service
> model for the 'Portal API' that isn't dependent on anything else. The
> committers to this service will be able to describe this more, but they are
> in Europe so it probably won't be til tomorrow.
Ok, I'm *strongly* -1 on any more Services frameworks being built.
Please look at the BaseService class in Turbine. It is a very clean
framework for building Services. One could easily build a PortletService on
top of BaseService....instead of having it built on top of TurbineServices.
If you look at the BaseService, it does nothing more than import java.util.
There is zero dependencies on any of the rest of the system.
> Damn, now I suppose that everytime you see my name, you will think "iFoo",
> or even worse, the "iFoo Propagator".
> Where's there a corner I can hide in....
Oh, don't say immature things when someone simply asks why things are being
done the way that things are being done. This project has a long history of
not doing things properly...work to fix it, not to make it worse.
thanks,
-jon
--
--------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/[email protected]/>
List Help?: [EMAIL PROTECTED]
