On Sun, 2008-03-09 at 18:23 +0100, Christian Kujau wrote:
> On Sun, 9 Mar 2008, Miha Verlic wrote:
> > I googled around a bit, and it seems there is different version (though
> > labled the same) available on
> > http://www.kernel.org/pub/linux/kernel/people/shaggy/jfs/jfsutils-1.1.12.tar.gz.
> > This one appears to work ok.

That was was built with an older version of autoconf.

> Crazy. However, both versions only differ in the build scripts:

Some change to autoconf made fseeko fail to compile correctly for large
offsets when built against glibc-2.3.

> Files jfsutils-1.1.12_kernel.org/aclocal.m4 and jfsutils-1.1.12_SF/aclocal.m4 
> differ
> Files jfsutils-1.1.12_kernel.org/configure and jfsutils-1.1.12_SF/configure 
> differ
> Files jfsutils-1.1.12_kernel.org/include/jfs_version.h and 
> jfsutils-1.1.12_SF/include/jfs_version.h differ
> 
> I wonder why this made jfs.fsck to fail...

I worked around it with this patch in cvs, but I haven't built a
jfsutils-1.1.13 yet.  I'll try to get that out soon.

Index: libfs/devices.c
===================================================================
RCS file: /cvsroot/jfs/jfsutils/libfs/devices.c,v
retrieving revision 1.22
retrieving revision 1.23
diff -u -p -r1.22 -r1.23
--- libfs/devices.c     7 Apr 2007 17:09:56 -0000       1.22
+++ libfs/devices.c     14 Jan 2008 15:05:16 -0000      1.23
@@ -1,5 +1,5 @@
 /*
- *   Copyright (c) International Business Machines Corp., 2000-2003
+ *   Copyright (c) International Business Machines Corp., 2000-2008
  *
  *   This program is free software;  you can redistribute it and/or modify
  *   it under the terms of the GNU General Public License as published by
@@ -15,6 +15,13 @@
  *   along with this program;  if not, write to the Free Software
  *   Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
  */
+
+/*
+ * autoconf 2.61 causes fseeko to miscompile against glibc-2.3.
+ * Override config.h by defining _LARGEFILE_SOURCE here
+ */
+#define _LARGEFILE_SOURCE
+
 #include <config.h>
 #include <errno.h>
 #include <fcntl.h>

-- 
David Kleikamp
IBM Linux Technology Center


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Jfs-discussion mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jfs-discussion

Reply via email to